[Scummvm-cvs-logs] scummvm master -> 4f6d42d77b5284552b12a7c0f427e060b27c3077
wjp
wjp at usecode.org
Sun May 13 16:24:57 CEST 2012
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
4f6d42d77b SCI: Add a few FIXMEs
Commit: 4f6d42d77b5284552b12a7c0f427e060b27c3077
https://github.com/scummvm/scummvm/commit/4f6d42d77b5284552b12a7c0f427e060b27c3077
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2012-05-13T07:23:15-07:00
Commit Message:
SCI: Add a few FIXMEs
Changed paths:
engines/sci/resource.cpp
engines/sci/resource.h
diff --git a/engines/sci/resource.cpp b/engines/sci/resource.cpp
index 77a6a40..11c3e2b 100644
--- a/engines/sci/resource.cpp
+++ b/engines/sci/resource.cpp
@@ -93,6 +93,8 @@ const char *getSciVersionDesc(SciVersion version) {
//#define SCI_VERBOSE_RESMAN 1
+// FIXME: This list is out of sync with the enum in resource.h with
+// its indices.
static const char *const sci_error_types[] = {
"No error",
"I/O error",
diff --git a/engines/sci/resource.h b/engines/sci/resource.h
index 294a467..6c2eb0b 100644
--- a/engines/sci/resource.h
+++ b/engines/sci/resource.h
@@ -54,6 +54,7 @@ enum ResourceStatus {
kResStatusLocked /**< Allocated and in use */
};
+// FIXME: This enum is out of sync with its textual descriptions in resource.cpp
/** Initialization result types */
enum {
SCI_ERROR_IO_ERROR = 1,
@@ -64,6 +65,7 @@ enum {
SCI_ERROR_DECOMPRESSION_ERROR = 6, /**< sanity checks failed during decompression */
SCI_ERROR_RESOURCE_TOO_BIG = 8 /**< Resource size exceeds SCI_MAX_RESOURCE_SIZE */
+ // FIXME: This comment makes no sense. Track down in history what it means:
/* the first critical error number */
};
More information about the Scummvm-git-logs
mailing list