[Scummvm-cvs-logs] scummvm master -> e77fc29101dfec7e5e35559783dd4e729df8a0c7
bluegr
md5 at scummvm.org
Sat May 26 18:08:20 CEST 2012
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
e77fc29101 SCI: Add a TODO in kFileIOReadRaw
Commit: e77fc29101dfec7e5e35559783dd4e729df8a0c7
https://github.com/scummvm/scummvm/commit/e77fc29101dfec7e5e35559783dd4e729df8a0c7
Author: Filippos Karapetis (md5 at scummvm.org)
Date: 2012-05-26T09:06:54-07:00
Commit Message:
SCI: Add a TODO in kFileIOReadRaw
Changed paths:
engines/sci/engine/kfile.cpp
diff --git a/engines/sci/engine/kfile.cpp b/engines/sci/engine/kfile.cpp
index b1f8522..8d1b078 100644
--- a/engines/sci/engine/kfile.cpp
+++ b/engines/sci/engine/kfile.cpp
@@ -812,6 +812,9 @@ reg_t kFileIOReadRaw(EngineState *s, int argc, reg_t *argv) {
FileHandle *f = getFileFromHandle(s, handle);
if (f) {
bytesRead = f->_in->read(buf, size);
+ // TODO: What happens if less bytes are read than what has
+ // been requested? (i.e. if bytesRead is non-zero, but still
+ // less than size)
if (bytesRead > 0)
s->_segMan->memcpy(argv[1], (const byte*)buf, size);
}
More information about the Scummvm-git-logs
mailing list