[Scummvm-cvs-logs] scummvm master -> cdf1900ce09afcef7d32d5126679730ada8f2a69

wjp wjp at usecode.org
Sun Apr 7 18:23:37 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
cdf1900ce0 SCI: Add signal/fade related CHECKME


Commit: cdf1900ce09afcef7d32d5126679730ada8f2a69
    https://github.com/scummvm/scummvm/commit/cdf1900ce09afcef7d32d5126679730ada8f2a69
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2013-04-07T09:22:41-07:00

Commit Message:
SCI: Add signal/fade related CHECKME

Changed paths:
    engines/sci/sound/soundcmd.cpp



diff --git a/engines/sci/sound/soundcmd.cpp b/engines/sci/sound/soundcmd.cpp
index 6fe35be..873a16c 100644
--- a/engines/sci/sound/soundcmd.cpp
+++ b/engines/sci/sound/soundcmd.cpp
@@ -517,6 +517,8 @@ void SoundCommandParser::processUpdateCues(reg_t obj) {
 		// fireworks).
 		// It is also needed in other games, e.g. LSL6 when talking to the
 		// receptionist (bug #3192166).
+		// CHECKME: At least kq5cd/win and kq6 set signal to 0xFE here, but
+		// kq5cd/dos does not set signal at all. Needs more investigation.
 		writeSelectorValue(_segMan, obj, SELECTOR(signal), SIGNAL_OFFSET);
 		if (_soundVersion <= SCI_VERSION_0_LATE) {
 			processStopSound(obj, false);






More information about the Scummvm-git-logs mailing list