[Scummvm-cvs-logs] scummvm master -> cca4e41bf10ea34a0e7cea186f2fb24b9a7d604f

eriktorbjorn eriktorbjorn at telia.com
Wed Aug 21 15:21:22 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
cca4e41bf1 TSAGE: Fix illegal address computation, CID 1047259


Commit: cca4e41bf10ea34a0e7cea186f2fb24b9a7d604f
    https://github.com/scummvm/scummvm/commit/cca4e41bf10ea34a0e7cea186f2fb24b9a7d604f
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2013-08-21T06:18:55-07:00

Commit Message:
TSAGE: Fix illegal address computation, CID 1047259

We want the address right after the last element of _fadePaletteMap.
There was probably no actual damage done since _paletteMap[] would
likely be right after in memory, and that's zeroed as well. But it
was still wrong.

Changed paths:
    engines/tsage/globals.cpp



diff --git a/engines/tsage/globals.cpp b/engines/tsage/globals.cpp
index 598aed4..6d1f4ce 100644
--- a/engines/tsage/globals.cpp
+++ b/engines/tsage/globals.cpp
@@ -389,7 +389,7 @@ void Ringworld2Globals::reset() {
 	_scrollFollower = &_player;
 
 	// Reset fields
-	Common::fill(&_fadePaletteMap[0][0], &_fadePaletteMap[10][256], 0);
+	Common::fill(&_fadePaletteMap[0][0], &_fadePaletteMap[9][256], 0);
 	Common::fill(&_paletteMap[0], &_paletteMap[4096], 0);
 
 	_fadePaletteFlag = false;






More information about the Scummvm-git-logs mailing list