[Scummvm-cvs-logs] scummvm master -> d7ff665737b3144b00d4808043402e1317ee234c

lordhoto lordhoto at gmail.com
Thu Jul 4 14:49:12 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
d7ff665737 AUDIO: Fix ReportHandlerScummVM::printDebug in MT32 code.


Commit: d7ff665737b3144b00d4808043402e1317ee234c
    https://github.com/scummvm/scummvm/commit/d7ff665737b3144b00d4808043402e1317ee234c
Author: Johannes Schickel (lordhoto at scummvm.org)
Date: 2013-07-04T05:44:41-07:00

Commit Message:
AUDIO: Fix ReportHandlerScummVM::printDebug in MT32 code.

Formerly it tried to pass 'va_list' as '...' to debug. Now it's first creating
a String containing the output via String::vformat and then passing it
to debug.

Found by buildbot (master-dc). The warning message was:
audio/softsynth/mt32.cpp:65: warning: cannot pass objects of non-POD type
`struct va_list' through `...'; call will abort at runtime

Changed paths:
    audio/softsynth/mt32.cpp



diff --git a/audio/softsynth/mt32.cpp b/audio/softsynth/mt32.cpp
index 00d0469..3281e3b 100644
--- a/audio/softsynth/mt32.cpp
+++ b/audio/softsynth/mt32.cpp
@@ -62,7 +62,8 @@ protected:
 
 	// Callback for debug messages, in vprintf() format
 	void printDebug(const char *fmt, va_list list) {
-		debug(4, fmt, list);
+		Common::String out = Common::String::vformat(fmt, list);
+		debug(4, out.c_str());
 	}
 
 	// Callbacks for reporting various errors and information






More information about the Scummvm-git-logs mailing list