[Scummvm-cvs-logs] scummvm master -> 71ed35502e218a11c16af624ef5a0a77296184cf

eriktorbjorn eriktorbjorn at telia.com
Fri Jul 19 20:52:28 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
71ed35502e TEENAGENT: Add missing "break"s to switch cases


Commit: 71ed35502e218a11c16af624ef5a0a77296184cf
    https://github.com/scummvm/scummvm/commit/71ed35502e218a11c16af624ef5a0a77296184cf
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2013-07-19T11:49:15-07:00

Commit Message:
TEENAGENT: Add missing "break"s to switch cases

I think this is the correct thing to do, and that it won't have
any noticeable effect whatsoever.

Cases 29 and 30 happen in the first half of the game, in the
cantine, while case 42 happens in the second half of the game. By
the time you reach the point where case 42 does something, I don't
think it's possible to get back to cases 29 and 30, so when case
29 falls through neither 30 nor 42 will do anything.

CID 1003730, 1003731

Changed paths:
    engines/teenagent/resources.cpp



diff --git a/engines/teenagent/resources.cpp b/engines/teenagent/resources.cpp
index 442d0ab..399baf4 100644
--- a/engines/teenagent/resources.cpp
+++ b/engines/teenagent/resources.cpp
@@ -206,16 +206,19 @@ Common::SeekableReadStream *Resources::loadLan000(uint32 id) const {
 		if (dseg.get_byte(dsAddr_birdOnBarRadioAntennaFlag) == 1) {
 			return lan500.getStream(380);
 		}
+		break;
 
 	case 30:
 		if (dseg.get_byte(dsAddr_birdOnBarRadioAntennaFlag) == 1) {
 			return lan500.getStream(381);
 		}
+		break;
 
 	case 42:
 		if (dseg.get_byte(dsAddr_johnNotyOutsideMansionDoorFlag) == 1) {
 			return lan500.getStream(400);
 		}
+		break;
 	}
 	return lan000.getStream(id);
 }






More information about the Scummvm-git-logs mailing list