[Scummvm-cvs-logs] scummvm master -> 2ca36ab53aa9e8a6c0e3a51779087bb0e8d00cb1

bluegr bluegr at gmail.com
Sat Jun 15 14:08:12 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2ca36ab53a NEVERHOOD: Fix 2 off-by-one errors in the savegame slot selection box


Commit: 2ca36ab53aa9e8a6c0e3a51779087bb0e8d00cb1
    https://github.com/scummvm/scummvm/commit/2ca36ab53aa9e8a6c0e3a51779087bb0e8d00cb1
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2013-06-15T05:07:01-07:00

Commit Message:
NEVERHOOD: Fix 2 off-by-one errors in the savegame slot selection box

Changed paths:
    engines/neverhood/menumodule.cpp



diff --git a/engines/neverhood/menumodule.cpp b/engines/neverhood/menumodule.cpp
index afa2754..368bfd6 100644
--- a/engines/neverhood/menumodule.cpp
+++ b/engines/neverhood/menumodule.cpp
@@ -821,7 +821,7 @@ void SavegameListBox::scrollUp() {
 }
 
 void SavegameListBox::scrollDown() {
-	if (_lastVisibleItem < (int)_textLabelItems.size()) {
+	if (_lastVisibleItem < (int)_textLabelItems.size() - 1) {
 		++_firstVisibleItem;
 		++_lastVisibleItem;
 		refresh();
@@ -838,7 +838,7 @@ void SavegameListBox::pageUp() {
 }
 
 void SavegameListBox::pageDown() {
-	int amount = MIN((int)_textLabelItems.size() - _lastVisibleItem, _maxVisibleItemsCount);
+	int amount = MIN((int)_textLabelItems.size() - _lastVisibleItem - 1, _maxVisibleItemsCount);
 	if (amount > 0) {
 		_firstVisibleItem += amount;
 		_lastVisibleItem += amount;






More information about the Scummvm-git-logs mailing list