[Scummvm-cvs-logs] scummvm master -> 6e3510ac6154783a99b58bfae83c86145954435f

wjp wjp at usecode.org
Tue Jun 18 18:48:51 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
6e3510ac61 SCI: Add note about LSL1vga DoSoundSendMidi


Commit: 6e3510ac6154783a99b58bfae83c86145954435f
    https://github.com/scummvm/scummvm/commit/6e3510ac6154783a99b58bfae83c86145954435f
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2013-06-18T09:46:54-07:00

Commit Message:
SCI: Add note about LSL1vga DoSoundSendMidi

Changed paths:
    engines/sci/sound/soundcmd.cpp



diff --git a/engines/sci/sound/soundcmd.cpp b/engines/sci/sound/soundcmd.cpp
index daba976..9f3deca 100644
--- a/engines/sci/sound/soundcmd.cpp
+++ b/engines/sci/sound/soundcmd.cpp
@@ -534,8 +534,11 @@ reg_t SoundCommandParser::kDoSoundSendMidi(int argc, reg_t *argv, reg_t acc) {
 	byte channel = argv[1].toUint16() & 0xf;
 	byte midiCmd = argv[2].toUint16() & 0xff;
 
-	// TODO: first there is a 4-parameter variant of this call which needs to get reversed
-	//        second the current code isn't 100% accurate, sierra sci does checks on the 4th parameter
+	// TODO: There is a 4 parameter variant of this call,
+	// used by at least lsl1vga.
+	// It lacks a midiCmd argument, but for this variant midiCmd defaults to
+	// 0xB0 (controller). If argv[2] is 0xFF, midiCmd is 0xE0
+	// (pitchwheel). The exact parameters need to be investigated further.
 	if (argc == 4)
 		return acc;
 






More information about the Scummvm-git-logs mailing list