[Scummvm-cvs-logs] scummvm master -> 217164c6c9b17e46f38e02acdc2450caf7fcc21a

dreammaster dreammaster at scummvm.org
Fri Nov 1 01:09:52 CET 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
217164c6c9 TSAGE: Improved comments about uninitialised variable in original code


Commit: 217164c6c9b17e46f38e02acdc2450caf7fcc21a
    https://github.com/scummvm/scummvm/commit/217164c6c9b17e46f38e02acdc2450caf7fcc21a
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2013-10-31T17:09:13-07:00

Commit Message:
TSAGE: Improved comments about uninitialised variable in original code

Changed paths:
    engines/tsage/ringworld2/ringworld2_scenes1.cpp



diff --git a/engines/tsage/ringworld2/ringworld2_scenes1.cpp b/engines/tsage/ringworld2/ringworld2_scenes1.cpp
index 453d120..7c9c541 100644
--- a/engines/tsage/ringworld2/ringworld2_scenes1.cpp
+++ b/engines/tsage/ringworld2/ringworld2_scenes1.cpp
@@ -8267,8 +8267,10 @@ void Scene1550::dispatch() {
 
 	if ((R2_GLOBALS._s1550PlayerArea[R2_GLOBALS._player._characterIndex].x == 15) && (R2_GLOBALS._s1550PlayerArea[R2_GLOBALS._player._characterIndex].y == 16)) {
 		R2_GLOBALS._player._shade = 0;
-		// Original game contains a switch based on an uninitialized variable.
-		// Until we understand what should really happen there, this code is unused on purpose
+
+		// WORKAROUND: Original game contains a switch based on an uninitialized variable.
+		// The switch is being left in place, but with a fixed switch value of zero, in case
+		// we can ever figure out what the original programmers intended the value to come from
 		int missingVariable = 0;
 		switch (missingVariable) {
 		case 144:






More information about the Scummvm-git-logs mailing list