[Scummvm-cvs-logs] scummvm master -> 8cc82d0a0b290a5d7cfdd15b22304fe4e33422a2

wjp wjp at usecode.org
Sat Nov 23 16:12:25 CET 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
8cc82d0a0b SCI: Make fade signal version check more precise


Commit: 8cc82d0a0b290a5d7cfdd15b22304fe4e33422a2
    https://github.com/scummvm/scummvm/commit/8cc82d0a0b290a5d7cfdd15b22304fe4e33422a2
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2013-11-23T07:11:07-08:00

Commit Message:
SCI: Make fade signal version check more precise

Changed paths:
    engines/sci/sound/soundcmd.cpp



diff --git a/engines/sci/sound/soundcmd.cpp b/engines/sci/sound/soundcmd.cpp
index 92fbdbf..aa2a309 100644
--- a/engines/sci/sound/soundcmd.cpp
+++ b/engines/sci/sound/soundcmd.cpp
@@ -511,10 +511,12 @@ void SoundCommandParser::processUpdateCues(reg_t obj) {
 		// TODO: More thorougly check the different SCI version:
 		// * SCI1late sets signal to 0xFE here. (With signal 0xFF
 		//       duplicate music plays in LauraBow2CD - bug #6462)
+		//   SCI1middle LSL1 1.000.510 does not have the 0xFE;
+		//   SCI1late CastleDrBrain demo 1.000.005 does have the 0xFE.
 		// * Other SCI1 games seem to rely on processStopSound to set the signal
 		// * Need to check SCI0 behaviour.
 		uint16 sig;
-		if (_soundVersion >= SCI_VERSION_1_LATE)
+		if (getSciVersion() >= SCI_VERSION_1_LATE)
 			sig = 0xFFFE;
 		else
 			sig = SIGNAL_OFFSET;






More information about the Scummvm-git-logs mailing list