[Scummvm-cvs-logs] scummvm master -> 303261482de2f2c1bf1f1fb4d2e016b0555ba715

clone2727 clone2727 at gmail.com
Mon Oct 7 04:43:30 CEST 2013


This automated email contains information about 4 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
29fae78630 PEGASUS: Fix disabling the retinal hotspot
3ca434dea3 PEGASUS: Add back missing silos deactivated sound spot
06c4c11bf8 PEGASUS: Fix incorrect displaying of the synthesizer shutdown video
303261482d CREDITS: Add Keith for some pegasus patches


Commit: 29fae786302b64917d7fc839d9cb3a20807ddab3
    https://github.com/scummvm/scummvm/commit/29fae786302b64917d7fc839d9cb3a20807ddab3
Author: Keith Kaisershot (keithkaisershot at gmail.com)
Date: 2013-10-06T16:36:18-07:00

Commit Message:
PEGASUS: Fix disabling the retinal hotspot

Changed paths:
    engines/pegasus/neighborhood/norad/delta/noraddelta.cpp



diff --git a/engines/pegasus/neighborhood/norad/delta/noraddelta.cpp b/engines/pegasus/neighborhood/norad/delta/noraddelta.cpp
index f2ea53f..1eea2f0 100644
--- a/engines/pegasus/neighborhood/norad/delta/noraddelta.cpp
+++ b/engines/pegasus/neighborhood/norad/delta/noraddelta.cpp
@@ -565,6 +565,11 @@ void NoradDelta::activateHotspots() {
 	} else if (GameState.getCurrentRoomAndView() == MakeRoomView(kNorad59, kWest)) {
 		if (GameState.isCurrentDoorOpen())
 			_vm->getAllHotspots().deactivateOneHotspot(kNorad59WestSpotID);
+	} else if (GameState.getCurrentRoomAndView() == MakeRoomView(kNorad68, kWest)) {
+		// WORKAROUND: Make sure the retinal hotspot is disabled after the door opens.
+		// Fixes a bug in the original.
+		if (GameState.isCurrentDoorOpen())
+			_vm->getAllHotspots().deactivateOneHotspot(kNorad68WestSpotID);
 	}
 }
 


Commit: 3ca434dea3ff9d54563d35c96fd3368177846e9b
    https://github.com/scummvm/scummvm/commit/3ca434dea3ff9d54563d35c96fd3368177846e9b
Author: Keith Kaisershot (keithkaisershot at gmail.com)
Date: 2013-10-06T19:41:25-07:00

Commit Message:
PEGASUS: Add back missing silos deactivated sound spot

Changed paths:
    engines/pegasus/neighborhood/norad/delta/globegame.cpp



diff --git a/engines/pegasus/neighborhood/norad/delta/globegame.cpp b/engines/pegasus/neighborhood/norad/delta/globegame.cpp
index 1416c51..0b95e9b 100644
--- a/engines/pegasus/neighborhood/norad/delta/globegame.cpp
+++ b/engines/pegasus/neighborhood/norad/delta/globegame.cpp
@@ -905,6 +905,11 @@ void GlobeGame::clickGlobe(const Input &input) {
 				_monitorMovie.start();
 				_owner->requestSpotSound(kMaximumDeactivationIn, kMaximumDeactivationOut,
 						kFilterNoInput, kSpotSoundCompletedFlag);
+
+				// This sound was left out of the original.
+				_owner->requestSpotSound(kAllSilosDeactivatedIn, kAllSilosDeactivatedOut,
+						kFilterNoInput, kSpotSoundCompletedFlag);
+
 				_gameState = kPlayerWon1;
 			} else {
 				_owner->requestDelay(2, 1, kFilterNoInput, kDelayCompletedFlag);
@@ -1060,12 +1065,13 @@ void GlobeGame::doSolve() {
 	_upperNamesMovie.hide();
 	_lowerNamesMovie.hide();
 	_countdown.hide();
-	_monitorMovie.setSegment(kMaxDeactivatedStart * _monitorMovie.getScale(), kMaxDeactivatedStop * _monitorMovie.getScale());
-	_monitorMovie.setTime(kMaxDeactivatedStart * _monitorMovie.getScale());
+	_monitorMovie.setSegment(kMaxDeactivatedStart * _monitorMovie.getScale() + (kSiloDeactivatedOut - kSiloDeactivatedIn), kMaxDeactivatedStop * _monitorMovie.getScale());
+	_monitorMovie.setTime(kMaxDeactivatedStart * _monitorMovie.getScale() + (kSiloDeactivatedOut - kSiloDeactivatedIn));
 	_monitorCallBack.setCallBackFlag(kMaxDeactivatedFinished);
 	_monitorCallBack.scheduleCallBack(kTriggerAtStop, 0, 0);
 	_monitorMovie.start();
 	_owner->requestSpotSound(kMaximumDeactivationIn, kMaximumDeactivationOut, kFilterNoInput, kSpotSoundCompletedFlag);
+	_owner->requestSpotSound(kAllSilosDeactivatedIn, kAllSilosDeactivatedOut, kFilterNoInput, kSpotSoundCompletedFlag);
 	_gameState = kPlayerWon1;
 }
 


Commit: 06c4c11bf8b879f155b99feb63baa364686930f5
    https://github.com/scummvm/scummvm/commit/06c4c11bf8b879f155b99feb63baa364686930f5
Author: Keith Kaisershot (keithkaisershot at gmail.com)
Date: 2013-10-06T19:41:30-07:00

Commit Message:
PEGASUS: Fix incorrect displaying of the synthesizer shutdown video

Changed paths:
    engines/pegasus/neighborhood/tsa/fulltsa.cpp
    engines/pegasus/neighborhood/tsa/tinytsa.cpp
    engines/pegasus/neighborhood/wsc/wsc.cpp



diff --git a/engines/pegasus/neighborhood/tsa/fulltsa.cpp b/engines/pegasus/neighborhood/tsa/fulltsa.cpp
index 9b843da..99efe10 100644
--- a/engines/pegasus/neighborhood/tsa/fulltsa.cpp
+++ b/engines/pegasus/neighborhood/tsa/fulltsa.cpp
@@ -2653,7 +2653,6 @@ void FullTSA::receiveNotification(Notification *notification, const Notification
 				GameState.setWSCAnalyzerOn(false);
 				GameState.setWSCDartInAnalyzer(false);
 				GameState.setWSCAnalyzedDart(false);
-				GameState.setWSCPickedUpAntidote(false);
 				GameState.setWSCSawMorph(false);
 				GameState.setWSCDesignedAntidote(false);
 				GameState.setWSCOfficeMessagesOpen(false);
diff --git a/engines/pegasus/neighborhood/tsa/tinytsa.cpp b/engines/pegasus/neighborhood/tsa/tinytsa.cpp
index 4f10962..0d11f5d 100644
--- a/engines/pegasus/neighborhood/tsa/tinytsa.cpp
+++ b/engines/pegasus/neighborhood/tsa/tinytsa.cpp
@@ -337,7 +337,6 @@ void TinyTSA::receiveNotification(Notification *notification, const Notification
 				GameState.setWSCRemovedDart(false);
 				GameState.setWSCAnalyzerOn(false);
 				GameState.setWSCAnalyzedDart(false);
-				GameState.setWSCPickedUpAntidote(false);
 				GameState.setWSCSawMorph(false);
 				GameState.setWSCDesignedAntidote(false);
 				GameState.setWSCOfficeMessagesOpen(false);
diff --git a/engines/pegasus/neighborhood/wsc/wsc.cpp b/engines/pegasus/neighborhood/wsc/wsc.cpp
index 50b7774..09e2a48 100644
--- a/engines/pegasus/neighborhood/wsc/wsc.cpp
+++ b/engines/pegasus/neighborhood/wsc/wsc.cpp
@@ -2336,13 +2336,16 @@ Hotspot *WSC::getItemScreenSpot(Item *item, DisplayElement *element) {
 void WSC::pickedUpItem(Item *item) {
 	switch (item->getObjectID()) {
 	case kAntidote:
+		// WORKAROUND: Make sure the poison is cleared separately from deactivating
+		// the synthesizer video.
+		GameState.setWSCPoisoned(false);
+		GameState.setWSCRemovedDart(false);
+		_privateFlags.setFlag(kWSCDraggingAntidoteFlag, false);
+		playSpotSoundSync(kDrinkAntidoteIn, kDrinkAntidoteOut);
+		setUpPoison();
+
 		if (!GameState.getWSCPickedUpAntidote()) {
-			GameState.setWSCPoisoned(false);
-			GameState.setWSCRemovedDart(false);
 			GameState.setWSCPickedUpAntidote(true);
-			_privateFlags.setFlag(kWSCDraggingAntidoteFlag, false);
-			playSpotSoundSync(kDrinkAntidoteIn, kDrinkAntidoteOut);
-			setUpPoison();
 			startExtraSequence(kW03SouthDeactivate, kExtraCompletedFlag, kFilterNoInput);
 		}
 		break;


Commit: 303261482de2f2c1bf1f1fb4d2e016b0555ba715
    https://github.com/scummvm/scummvm/commit/303261482de2f2c1bf1f1fb4d2e016b0555ba715
Author: Matthew Hoops (clone2727 at gmail.com)
Date: 2013-10-06T19:41:30-07:00

Commit Message:
CREDITS: Add Keith for some pegasus patches

Changed paths:
    AUTHORS
    devtools/credits.pl
    gui/credits.h



diff --git a/AUTHORS b/AUTHORS
index fd5407b..e0f1a1b 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -510,6 +510,7 @@ Other contributions
      Janne Huttunen          - V3 actor mask support, Dig/FT SMUSH audio
      Kovacs Endre Janos      - Several fixes for Simon1
      Jeroen Janssen          - Numerous readability and bugfix patches
+     Keith Kaisershot        - Several Pegasus Prime patches
      Andreas Karlsson        - Initial port for SymbianOS
      Claudio Matsuoka        - Daily Linux builds
      Thomas Mayer            - PSP port contributions
diff --git a/devtools/credits.pl b/devtools/credits.pl
index 45018a5..ecb543b 100755
--- a/devtools/credits.pl
+++ b/devtools/credits.pl
@@ -1063,6 +1063,7 @@ begin_credits("Credits");
 				add_person("Janne Huttunen", "", "V3 actor mask support, Dig/FT SMUSH audio");
 				add_person("Kovács Endre János", "", "Several fixes for Simon1");
 				add_person("Jeroen Janssen", "japj", "Numerous readability and bugfix patches");
+				add_person("Keith Kaisershot", "blitter", "Several Pegasus Prime patches");
 				add_person("Andreas Karlsson", "Sprawl", "Initial port for SymbianOS");
 				add_person("Claudio Matsuoka", "", "Daily Linux builds");
 				add_person("Thomas Mayer", "", "PSP port contributions");
diff --git a/gui/credits.h b/gui/credits.h
index 3a4d776..423b488 100644
--- a/gui/credits.h
+++ b/gui/credits.h
@@ -618,6 +618,8 @@ static const char *credits[] = {
 "C2""Several fixes for Simon1",
 "C0""Jeroen Janssen",
 "C2""Numerous readability and bugfix patches",
+"C0""Keith Kaisershot",
+"C2""Several Pegasus Prime patches",
 "C0""Andreas Karlsson",
 "C2""Initial port for SymbianOS",
 "C0""Claudio Matsuoka",






More information about the Scummvm-git-logs mailing list