[Scummvm-cvs-logs] scummvm master -> 7bdf48170a86fddca28350afac5b90981be0d9a0

DrMcCoy drmccoy at drmccoy.de
Sun Oct 19 00:10:18 CEST 2014


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
7bdf48170a GOB: Remove useless memcpy()


Commit: 7bdf48170a86fddca28350afac5b90981be0d9a0
    https://github.com/scummvm/scummvm/commit/7bdf48170a86fddca28350afac5b90981be0d9a0
Author: Sven Hesse (drmccoy at users.sourceforge.net)
Date: 2014-10-19T00:08:32+02:00

Commit Message:
GOB: Remove useless memcpy()

Happened while removing Draw::_vgaSmallPalette in 0f9b1364c.

Fixes Coverity issue #1230309.

Changed paths:
    engines/gob/inter_v1.cpp



diff --git a/engines/gob/inter_v1.cpp b/engines/gob/inter_v1.cpp
index 40134bb..676564a 100644
--- a/engines/gob/inter_v1.cpp
+++ b/engines/gob/inter_v1.cpp
@@ -1124,8 +1124,6 @@ void Inter_v1::o1_palLoad(OpFuncParams &params) {
 			_vm->_draw->_vgaPalette[i].green = _vm->_game->_script->readByte();
 			_vm->_draw->_vgaPalette[i].blue  = _vm->_game->_script->readByte();
 		}
-
-		memcpy(_vm->_draw->_vgaPalette, _vm->_draw->_vgaPalette, 16 * 3);
 		break;
 
 	case 53:






More information about the Scummvm-git-logs mailing list