[Scummvm-cvs-logs] scummvm master -> aa518306b8a82e22806cdb9820a6ac217a06c16f

johndoe123 benjamin.haisch at t-online.de
Sun Feb 1 17:22:46 CET 2015


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
aa518306b8 BBVS: Fix out-of-bounds array access in air guitar minigame as reported by Coverity


Commit: aa518306b8a82e22806cdb9820a6ac217a06c16f
    https://github.com/scummvm/scummvm/commit/aa518306b8a82e22806cdb9820a6ac217a06c16f
Author: johndoe123 (john_doe at techie.com)
Date: 2015-02-01T17:21:34+01:00

Commit Message:
BBVS: Fix out-of-bounds array access in air guitar minigame as reported by Coverity

Changed paths:
    engines/bbvs/minigames/bbairguitar.cpp



diff --git a/engines/bbvs/minigames/bbairguitar.cpp b/engines/bbvs/minigames/bbairguitar.cpp
index 6f198cb..26e27a9 100644
--- a/engines/bbvs/minigames/bbairguitar.cpp
+++ b/engines/bbvs/minigames/bbairguitar.cpp
@@ -1121,7 +1121,7 @@ void MinigameBbAirGuitar::noteOff(int noteNum) {
 		if (_actionTrackPos + _ticksDelta > 15000)
 			_ticksDelta = 15000 - _actionTrackPos;
 		_track[_trackCount].ticks = _ticksDelta;
-		if (_trackCount < 2048)
+		if (_trackCount + 1 < 2048)
 			++_trackCount;
 		_track[_trackCount].noteNum = -2;
 		_noteStartTime = _vm->_system->getMillis();






More information about the Scummvm-git-logs mailing list