[Scummvm-cvs-logs] scummvm master -> 750d72812b36bfed3043080d633798854dc4008d

bluegr bluegr at gmail.com
Tue Jan 20 01:17:23 CET 2015


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
750d72812b ZVISION: Properly skip commented out puzzle criteria - fixes bug #6776


Commit: 750d72812b36bfed3043080d633798854dc4008d
    https://github.com/scummvm/scummvm/commit/750d72812b36bfed3043080d633798854dc4008d
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2015-01-20T02:16:21+02:00

Commit Message:
ZVISION: Properly skip commented out puzzle criteria - fixes bug #6776

In the Zork: Nemesis version bundled in the ZGI SE DVD, the bell rope
puzzle has been modified so that it's non-interactive, i.e. there isn't
a hotspot to click while the video is playing, and the player is
transported to the next room. In the patched script, all criteria of
that puzzle were commented out, resulting in an invalid criteria list.
Skip any commented out criteria, to avoid ending with an invalid list.

Changed paths:
    engines/zvision/scripting/scr_file_handling.cpp



diff --git a/engines/zvision/scripting/scr_file_handling.cpp b/engines/zvision/scripting/scr_file_handling.cpp
index b4da61a..277702d 100644
--- a/engines/zvision/scripting/scr_file_handling.cpp
+++ b/engines/zvision/scripting/scr_file_handling.cpp
@@ -104,6 +104,13 @@ bool ScriptManager::parseCriteria(Common::SeekableReadStream &stream, Common::Li
 	Common::String line = stream.readLine();
 	trimCommentsAndWhiteSpace(&line);
 
+	// Skip any commented out criteria. If all the criteria are commented out,
+	// we might end up with an invalid criteria list (bug #6776).
+	while (line.empty()) {
+		line = stream.readLine();
+		trimCommentsAndWhiteSpace(&line);
+	}
+
 	// Criteria can be empty
 	if (line.contains('}')) {
 		return false;






More information about the Scummvm-git-logs mailing list