[Scummvm-cvs-logs] scummvm master -> 6d08055db3368dbaadb22e82d78c86bcb1026950
eriktorbjorn
eriktorbjorn at telia.com
Thu May 21 22:50:38 CEST 2015
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
6d08055db3 KYRA: Update comment since the file it pointed to moved
Commit: 6d08055db3368dbaadb22e82d78c86bcb1026950
https://github.com/scummvm/scummvm/commit/6d08055db3368dbaadb22e82d78c86bcb1026950
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2015-05-21T22:49:29+02:00
Commit Message:
KYRA: Update comment since the file it pointed to moved
Also, ScummVM does have a more modern FMOPL implementation now, so
there's no need to bring up other implementations.
Changed paths:
engines/kyra/sound_adlib.cpp
diff --git a/engines/kyra/sound_adlib.cpp b/engines/kyra/sound_adlib.cpp
index 89ee41e..c0e0f67 100644
--- a/engines/kyra/sound_adlib.cpp
+++ b/engines/kyra/sound_adlib.cpp
@@ -947,15 +947,10 @@ void AdLibDriver::unkOutput2(uint8 chan) {
//
// This is very strange behavior, and causes problems with the ancient
// FMOPL code we borrowed from AdPlug. I've added a workaround. See
- // fmopl.cpp for more details.
+ // audio/softsynth/opl/mame.cpp for more details.
//
- // More recent versions of the MAME FMOPL don't seem to have this
- // problem, but cannot currently be used because of licensing and
- // performance issues.
- //
- // Ken Silverman's AdLib emulator (which can be found on his Web page -
- // http://www.advsys.net/ken - and as part of AdPlug) also seems to be
- // immune, but is apparently not as feature complete as MAME's.
+ // Fortunately, the more modern DOSBox FMOPL code does not seem to have
+ // any trouble with this.
writeOPL(0xB0 + chan, 0x20);
}
More information about the Scummvm-git-logs
mailing list