[Scummvm-cvs-logs] scummvm master -> 035aa9acf4c1d64e8fbbfb928a823c7a008c241e

m-kiewitz m_kiewitz at users.sourceforge.net
Mon Aug 15 20:44:32 CEST 2016


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
035aa9acf4 SCI: Add comments about GK1 on Mac being hi-res only


Commit: 035aa9acf4c1d64e8fbbfb928a823c7a008c241e
    https://github.com/scummvm/scummvm/commit/035aa9acf4c1d64e8fbbfb928a823c7a008c241e
Author: Martin Kiewitz (m_kiewitz at users.sourceforge.net)
Date: 2016-08-15T20:44:58+02:00

Commit Message:
SCI: Add comments about GK1 on Mac being hi-res only

Changed paths:
    engines/sci/detection_tables.h
    engines/sci/sci.cpp



diff --git a/engines/sci/detection_tables.h b/engines/sci/detection_tables.h
index 65e6df0..d8cc23a 100644
--- a/engines/sci/detection_tables.h
+++ b/engines/sci/detection_tables.h
@@ -829,6 +829,9 @@ static const struct ADGameDescription SciGameDescriptions[] = {
 		Common::ES_ESP, Common::kPlatformWindows, ADGF_CD | ADGF_UNSTABLE, GUIO_GK1_CD },
 
 	// Gabriel Knight - English Macintosh
+	// This version is hi-res ONLY, so it should NOT get GAMEOPTION_HIGH_RESOLUTION_GRAPHICS
+	// (which is meant for enforcing hi-res graphics), but instead hi-res mode should be enabled all the time.
+	// Confirmed by [md5] and originally by clone2727.
 	{"gk1", "", {
 		{"Data1", 0, "044d3bcd7e5b5bb0393d954ade8053fe", 5814918},
 		{"Data2", 0, "99a0c63febf9e44e12a00f99c00eae0f", 6685352},
diff --git a/engines/sci/sci.cpp b/engines/sci/sci.cpp
index 9ec8035..2a098ad 100644
--- a/engines/sci/sci.cpp
+++ b/engines/sci/sci.cpp
@@ -251,7 +251,9 @@ Common::Error SciEngine::run() {
 	//  - Gabriel Knight 1 CD
 	//  - Police Quest 4 CD
 	// TODO: Check, if Gabriel Knight 1 floppy supports high resolution
-	// TODO: Check, if Gabriel Knight 1 on Mac supports high resolution
+	//
+	// Gabriel Knight 1 on Mac is hi-res only, so it should NOT get this option.
+	// Confirmed by [md5] and originally by clone2727.
 	if (Common::checkGameGUIOption(GAMEOPTION_HIGH_RESOLUTION_GRAPHICS, ConfMan.get("guioptions"))) {
 		// GAMEOPTION_HIGH_RESOLUTION_GRAPHICS is available for the currently detected game,
 		// so read the user option now.






More information about the Scummvm-git-logs mailing list