[Scummvm-cvs-logs] scummvm master -> e24fbf7d6e422ab188910e9a5f8c7fd5c190ac35

m-kiewitz m_kiewitz at users.sourceforge.net
Sun Feb 14 02:06:46 CET 2016


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
e24fbf7d6e AGI: Fix another comment about dynamic priority table


Commit: e24fbf7d6e422ab188910e9a5f8c7fd5c190ac35
    https://github.com/scummvm/scummvm/commit/e24fbf7d6e422ab188910e9a5f8c7fd5c190ac35
Author: Martin Kiewitz (m_kiewitz at users.sourceforge.net)
Date: 2016-02-14T02:06:50+01:00

Commit Message:
AGI: Fix another comment about dynamic priority table

Available also in 2.425, then removed until 2.936, yada yada.
priorityToY-Glitch is definitely present in 2.425 as well.

Changed paths:
    engines/agi/graphics.cpp



diff --git a/engines/agi/graphics.cpp b/engines/agi/graphics.cpp
index e1ae62e..6f4b272 100644
--- a/engines/agi/graphics.cpp
+++ b/engines/agi/graphics.cpp
@@ -821,7 +821,8 @@ int16 GfxMgr::priorityToY(int16 priority) {
 		return (priority - 5) * 12 + 48;
 	}
 
-	// dynamic priority bands were introduced in 2.936 (effectively last version of AGI2)
+	// Dynamic priority bands were introduced in 2.425, but removed again until 2.936 (effectively last version of AGI2)
+	// They are available from 2.936 onwards.
 	// It seems there was a glitch, that caused priority bands to not get calculated properly.
 	// It was caused by this function starting with Y = 168 instead of 167, which meant it always
 	// returned with 168 as result.
@@ -832,6 +833,8 @@ int16 GfxMgr::priorityToY(int16 priority) {
 	//  drawn first, followed by ego, which would then draw ego over the dwarf.
 	//  For more information see bug #1712585 (dwarf sprite priority)
 	//
+	// This glitch is definitely present in 2.425, 2.936 and 3.002.086.
+	//
 	// Priority bands were working properly in: 3.001.098 (Black Cauldron)
 	uint16 agiVersion = _vm->getVersion();
 






More information about the Scummvm-git-logs mailing list