[Scummvm-cvs-logs] scummvm branch-1-8 -> 2df8d29e4aed4cf846dfbf66d5a0aa509aa58902

lordhoto lordhoto at gmail.com
Wed Feb 17 16:24:30 CET 2016


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2df8d29e4a SDL: Work around bug #7038 by limiting mode reset to Win32.


Commit: 2df8d29e4aed4cf846dfbf66d5a0aa509aa58902
    https://github.com/scummvm/scummvm/commit/2df8d29e4aed4cf846dfbf66d5a0aa509aa58902
Author: Johannes Schickel (lordhoto at scummvm.org)
Date: 2016-02-17T16:24:24+01:00

Commit Message:
SDL: Work around bug #7038 by limiting mode reset to Win32.

Bug is: "IRIX: X BadMatch when trying to start any 640x480 game".

40e019efd45a02261a7dbc69ceaa9188d8c7a269 introduced resetting the pixel depth
when unloading modes for SDL output. This was required to make mode listing
for OpenGL work on Win8+.

This causes issues on non-Win32 platforms though. SDL might not give us a valid
a pixel depth, causing the resetting to fail. A particular example is X11 on
IRIX, when only 16bit output modes work. Initially SDL tells us that the pixel
depth is 32bit. Trying to set this up causes a crash though.

Since there is no way to validate SDL's return value, we simply limit the reset
to platforms where it is actually required, i.e. Win32.

(cherry picked from commit fd688b73d75b06f96310d0151a2c9ef13d387f74)

Changed paths:
    backends/graphics/surfacesdl/surfacesdl-graphics.cpp
    backends/graphics/surfacesdl/surfacesdl-graphics.h








More information about the Scummvm-git-logs mailing list