[Scummvm-cvs-logs] scummvm-web master -> c2815c44ddab57053760f3e9f84ea366b3718db9

sev- sev at scummvm.org
Thu Jan 21 23:03:17 CET 2016


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm-web' repo located at https://github.com/scummvm/scummvm-web .

Summary:
5c27ce3e0e WEB: Fix language switching
c2815c44dd Merge pull request #16 from RichieSams/fix_lang_switching


Commit: 5c27ce3e0e0d9ed5be47afaab374fe6506ed88ee
    https://github.com/scummvm/scummvm-web/commit/5c27ce3e0e0d9ed5be47afaab374fe6506ed88ee
Author: Adrian Astley (adastley at gmail.com)
Date: 2016-01-21T12:43:43-06:00

Commit Message:
WEB: Fix language switching

As mentioned in f3c2203e2fc179e3f384e0499c34dcff63e792c1,
the language switching was always 1 behind. As in, the
language would be the last language you selected.

The first problem is that some of the smarty config variables
were being set after the call to _smarty->config_load(). Since
the smarty instance is cached, it was using the last set of variables.

I don't know why the production web site isn't throwing errors. My
personal set up wouldn't load until I could set _smarty->compile_dir
the first time. Perhaps the language update was done on the fly, so
smarty was still cached.

The next potential problem is persistence with $_SESSION.
The session is never initialized with session_start(). However,
the production php.ini may have session auto start enabled.

Changed paths:
    include/Controller.php
    index.php




Commit: c2815c44ddab57053760f3e9f84ea366b3718db9
    https://github.com/scummvm/scummvm-web/commit/c2815c44ddab57053760f3e9f84ea366b3718db9
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2016-01-21T23:03:15+01:00

Commit Message:
Merge pull request #16 from RichieSams/fix_lang_switching

WEB: Fix language switching

Changed paths:
    include/Controller.php
    index.php








More information about the Scummvm-git-logs mailing list