[Scummvm-cvs-logs] scummvm master -> d8e7d3cc355827a0a7dc3de4e77fade1ec13a10c

[sev-]

This automated email contains information about 4 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
ad3ab61241 COMMON: Remove the EventRecorder dependency from OSystem
8d34d5190d Revert "BUILD: Fix test compilation with event recorder enabled"
f980ef5524 BUILD: Don't disable the event recorder for TravisCI
d8e7d3cc35 Merge pull request #794 from bgK/fix-tests-event-recorder


Commit: ad3ab61241d5878c9b66f78f3927adb97f5a84e8
    https://github.com/scummvm/scummvm/commit/ad3ab61241d5878c9b66f78f3927adb97f5a84e8
Author: Bastien Bouclet (bastien.bouclet at gmail.com)
Date: 2016-07-28T18:23:46+02:00

Commit Message:
COMMON: Remove the EventRecorder dependency from OSystem

EventRecorder is in the gui lib which is not linked in the cxxtest suite.

Changed paths:
    backends/platform/sdl/sdl.cpp
    backends/platform/sdl/sdl.h
    common/system.cpp
    common/system.h



diff --git a/backends/platform/sdl/sdl.cpp b/backends/platform/sdl/sdl.cpp
index c557531..dca6891 100644
--- a/backends/platform/sdl/sdl.cpp
+++ b/backends/platform/sdl/sdl.cpp
@@ -492,6 +492,14 @@ AudioCDManager *OSystem_SDL::createAudioCDManager() {
 #endif
 }
 
+Common::SaveFileManager *OSystem_SDL::getSavefileManager() {
+#ifdef ENABLE_EVENTRECORDER
+    return g_eventRec.getSaveManager(_savefileManager);
+#else
+    return _savefileManager;
+#endif
+}
+
 #ifdef USE_OPENGL
 
 const OSystem::GraphicsMode *OSystem_SDL::getSupportedGraphicsModes() const {
diff --git a/backends/platform/sdl/sdl.h b/backends/platform/sdl/sdl.h
index c93c830..1fe670c 100644
--- a/backends/platform/sdl/sdl.h
+++ b/backends/platform/sdl/sdl.h
@@ -76,6 +76,7 @@ public:
 	virtual void getTimeAndDate(TimeDate &td) const;
 	virtual Audio::Mixer *getMixer();
 	virtual Common::TimerManager *getTimerManager();
+	virtual Common::SaveFileManager *getSavefileManager();
 
 protected:
 	bool _inited;
diff --git a/common/system.cpp b/common/system.cpp
index 53f28ca..131a7d2 100644
--- a/common/system.cpp
+++ b/common/system.cpp
@@ -30,9 +30,6 @@
 #include "common/taskbar.h"
 #include "common/updates.h"
 #include "common/textconsole.h"
-#ifdef ENABLE_EVENTRECORDER
-#include "gui/EventRecorder.h"
-#endif
 
 #include "backends/audiocd/default/default-audiocd.h"
 #include "backends/fs/fs-factory.h"
@@ -161,9 +158,5 @@ Common::TimerManager *OSystem::getTimerManager() {
 }
 
 Common::SaveFileManager *OSystem::getSavefileManager() {
-#ifdef ENABLE_EVENTRECORDER
-	return g_eventRec.getSaveManager(_savefileManager);
-#else
 	return _savefileManager;
-#endif
 }
diff --git a/common/system.h b/common/system.h
index 8896554..6d185d3 100644
--- a/common/system.h
+++ b/common/system.h
@@ -1090,7 +1090,7 @@ public:
 	 * and other modifiable persistent game data. For more information,
 	 * refer to the SaveFileManager documentation.
 	 */
-	Common::SaveFileManager *getSavefileManager();
+	virtual Common::SaveFileManager *getSavefileManager();
 
 #if defined(USE_TASKBAR)
 	/**


Commit: 8d34d5190db8a7af9a63c802e4f14a3b8a4ee7d1
    https://github.com/scummvm/scummvm/commit/8d34d5190db8a7af9a63c802e4f14a3b8a4ee7d1
Author: Bastien Bouclet (bastien.bouclet at gmail.com)
Date: 2016-07-28T18:23:50+02:00

Commit Message:
Revert "BUILD: Fix test compilation with event recorder enabled"

This reverts commit 1f8667c5d949070035390531e4f10c0f945d7352.

Changed paths:
    common/recorderfile.cpp
    common/scummsys.h
    test/module.mk



diff --git a/common/recorderfile.cpp b/common/recorderfile.cpp
index 04802aa..71f8272 100644
--- a/common/recorderfile.cpp
+++ b/common/recorderfile.cpp
@@ -30,8 +30,6 @@
 #include "graphics/surface.h"
 #include "graphics/scaler.h"
 
-#ifdef ENABLE_EVENTRECORDER
-
 #define RECORD_VERSION 1
 
 namespace Common {
@@ -716,5 +714,3 @@ void PlaybackFile::checkRecordedMD5() {
 
 
 }
-
-#endif // ENABLE_EVENTRECORDER
diff --git a/common/scummsys.h b/common/scummsys.h
index 3513ee2..5e1069f 100644
--- a/common/scummsys.h
+++ b/common/scummsys.h
@@ -215,10 +215,6 @@
 #include "config.h"
 #endif
 
-// Now we need to adjust some settings when running tests
-#ifdef COMPILING_TESTS
-#undef ENABLE_EVENTRECORDER
-#endif
 
 // In the following we configure various targets, in particular those
 // which can't use our "configure" tool and hence don't use config.h.
diff --git a/test/module.mk b/test/module.mk
index e591854..11ee6bd 100644
--- a/test/module.mk
+++ b/test/module.mk
@@ -26,7 +26,6 @@ endif
 #TEST_LDFLAGS += -L/usr/X11R6/lib -lX11
 
 
-test: CXXFLAGS +=  -DCOMPILING_TESTS=1
 test: test/runner
 	./test/runner
 test/runner: test/runner.cpp $(TEST_LIBS)


Commit: f980ef5524897eac047f0d794af3971c7c71a6a3
    https://github.com/scummvm/scummvm/commit/f980ef5524897eac047f0d794af3971c7c71a6a3
Author: Bastien Bouclet (bastien.bouclet at gmail.com)
Date: 2016-07-28T18:25:05+02:00

Commit Message:
BUILD: Don't disable the event recorder for TravisCI

Tests now build fine with the event recorder enabled

Changed paths:
    .travis.yml



diff --git a/.travis.yml b/.travis.yml
index 9965f16..0c88ec8 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -33,7 +33,7 @@ os:
   - linux
 
 script:
-  - ./configure --enable-all-engines --disable-eventrecorder
+  - ./configure --enable-all-engines
   - make -j 2
   - make test
   - make devtools


Commit: d8e7d3cc355827a0a7dc3de4e77fade1ec13a10c
    https://github.com/scummvm/scummvm/commit/d8e7d3cc355827a0a7dc3de4e77fade1ec13a10c
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2016-07-28T23:05:30+03:00

Commit Message:
Merge pull request #794 from bgK/fix-tests-event-recorder

COMMON: Fix tests when building with the event recorder

Changed paths:
    .travis.yml
    backends/platform/sdl/sdl.cpp
    backends/platform/sdl/sdl.h
    common/recorderfile.cpp
    common/scummsys.h
    common/system.cpp
    common/system.h
    test/module.mk