[Scummvm-git-logs] scummvm master -> b779f20502308c8db5c168c789f8867a13c8020b

digitall dgturner at iee.org
Tue Feb 28 21:36:18 CET 2017

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

b779f20502 CLOUD: Fix GCC Unused Variable Warning.

Commit: b779f20502308c8db5c168c789f8867a13c8020b
Author: D G Turner (digitall at scummvm.org)
Date: 2017-02-28T20:42:17Z

Commit Message:
CLOUD: Fix GCC Unused Variable Warning.

This variable is not used as the constructors for the storage type
classes store the resulting objects into the Cloud Manager using
replaceStorage(this) instead.

Changed paths:

diff --git a/backends/cloud/cloudmanager.cpp b/backends/cloud/cloudmanager.cpp
index 4fb38ad..5519e4b 100644
--- a/backends/cloud/cloudmanager.cpp
+++ b/backends/cloud/cloudmanager.cpp
@@ -253,27 +253,24 @@ void CloudManager::setStorageLastSync(uint32 index, Common::String date) {
 void CloudManager::connectStorage(uint32 index, Common::String code) {
-	Storage *storage = nullptr;
 	switch (index) {
 	case kStorageDropboxId:
-		storage = new Dropbox::DropboxStorage(code);
+		new Dropbox::DropboxStorage(code);
 	case kStorageOneDriveId:
-		storage = new OneDrive::OneDriveStorage(code);
+		new OneDrive::OneDriveStorage(code);
 	case kStorageGoogleDriveId:
-		storage = new GoogleDrive::GoogleDriveStorage(code);
+		new GoogleDrive::GoogleDriveStorage(code);
 	case kStorageBoxId:
-		storage = new Box::BoxStorage(code);
+		new Box::BoxStorage(code);
 	// in these constructors Storages request token using the passed code
 	// when the token is received, they call replaceStorage()
 	// or removeStorage(), if some error occurred
 	// thus, no memory leak happens
-	// FIXME: storage is set, but never used. Should it be returned from this function for class variable _storages?
 Networking::Request *CloudManager::listDirectory(Common::String path, Storage::ListDirectoryCallback callback, Networking::ErrorCallback errorCallback, bool recursive) {

More information about the Scummvm-git-logs mailing list