[Scummvm-git-logs] scummvm master -> df84aee6a30bf1e2e652f0dfc6fa54aa95b1091d

[digitall]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
df84aee6a3 CLOUD: Add FIXME comment.


Commit: df84aee6a30bf1e2e652f0dfc6fa54aa95b1091d
    https://github.com/scummvm/scummvm/commit/df84aee6a30bf1e2e652f0dfc6fa54aa95b1091d
Author: D G Turner (digitall at scummvm.org)
Date: 2017-01-10T05:19:13Z

Commit Message:
CLOUD: Add FIXME comment.

This is generating a compiler warning for set-but-unused, but it looks
as if this is meant to be used in some way i.e. code is unfinished or
orphaned.

Changed paths:
    backends/cloud/cloudmanager.cpp


diff --git a/backends/cloud/cloudmanager.cpp b/backends/cloud/cloudmanager.cpp
index 5f7d694..4fb38ad 100644
--- a/backends/cloud/cloudmanager.cpp
+++ b/backends/cloud/cloudmanager.cpp
@@ -272,6 +272,8 @@ void CloudManager::connectStorage(uint32 index, Common::String code) {
 	// when the token is received, they call replaceStorage()
 	// or removeStorage(), if some error occurred
 	// thus, no memory leak happens
+
+	// FIXME: storage is set, but never used. Should it be returned from this function for class variable _storages?
 }
 
 Networking::Request *CloudManager::listDirectory(Common::String path, Storage::ListDirectoryCallback callback, Networking::ErrorCallback errorCallback, bool recursive) {