[Scummvm-git-logs] scummvm master -> 6c4b89e6dc439299af68afaa75b366e4aece45c9

digitall dgturner at iee.org
Thu Jan 12 08:05:41 CET 2017


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
6c4b89e6dc MACVENTURE: Fix Comparison Always True Compiler Warning.


Commit: 6c4b89e6dc439299af68afaa75b366e4aece45c9
    https://github.com/scummvm/scummvm/commit/6c4b89e6dc439299af68afaa75b366e4aece45c9
Author: D G Turner (digitall at scummvm.org)
Date: 2017-01-12T07:11:46Z

Commit Message:
MACVENTURE: Fix Comparison Always True Compiler Warning.

There is no need for ABS() call as the parameters called on are both
unsigned integers.

Changed paths:
    engines/macventure/gui.cpp


diff --git a/engines/macventure/gui.cpp b/engines/macventure/gui.cpp
index 3b7c3a2..87d5161 100644
--- a/engines/macventure/gui.cpp
+++ b/engines/macventure/gui.cpp
@@ -335,7 +335,7 @@ WindowReference Gui::createInventoryWindow(ObjID objRef) {
 	Graphics::MacWindow *newWindow = _wm.addWindow(true, true, true);
 	WindowData newData;
 	GlobalSettings settings = _engine->getGlobalSettings();
-	newData.refcon = (WindowReference)ABS(_inventoryWindows.size() + kInventoryStart); // This is a HACK
+	newData.refcon = (WindowReference)(_inventoryWindows.size() + kInventoryStart); // This is a HACK
 
 	if (_windowData->back().refcon < 0x80) { // There is already another inventory window
 		newData.bounds = _windowData->back().bounds; // Inventory windows are always last





More information about the Scummvm-git-logs mailing list