[Scummvm-git-logs] scummvm master -> 23abcffbc5bc2f3e74d4725af1d292db0421054b

bgK bastien.bouclet at gmail.com
Mon May 8 06:59:35 CEST 2017


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
23abcffbc5 OPENGL: Don't update the cursor's texture when the cursor is invisible


Commit: 23abcffbc5bc2f3e74d4725af1d292db0421054b
    https://github.com/scummvm/scummvm/commit/23abcffbc5bc2f3e74d4725af1d292db0421054b
Author: Bastien Bouclet (bastien.bouclet at gmail.com)
Date: 2017-05-08T06:50:30+02:00

Commit Message:
OPENGL: Don't update the cursor's texture when the cursor is invisible

Updating the cursor's texture is not necessary if it is not going to be drawn.

Fixes glDrawArrays sometimes failing due to using a framebuffer with an
incomplete color attachment. In SCI32 games, the framebuffer is incomplete
because the engine does not define pixel data for the cursor.

Changed paths:
    backends/graphics/opengl/opengl-graphics.cpp


diff --git a/backends/graphics/opengl/opengl-graphics.cpp b/backends/graphics/opengl/opengl-graphics.cpp
index b239802..a595d07 100644
--- a/backends/graphics/opengl/opengl-graphics.cpp
+++ b/backends/graphics/opengl/opengl-graphics.cpp
@@ -402,7 +402,7 @@ void OpenGLGraphicsManager::updateScreen() {
 
 	// Update changes to textures.
 	_gameScreen->updateGLTexture();
-	if (_cursor) {
+	if (_cursorVisible && _cursor) {
 		_cursor->updateGLTexture();
 	}
 	_overlay->updateGLTexture();





More information about the Scummvm-git-logs mailing list