[Scummvm-git-logs] scummvm master -> cb5436dd16653b01fa5834f573b0aa6954744a30

sev- sev at scummvm.org
Wed Jan 31 18:37:51 CET 2018


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
cb5436dd16 TUCKER: Clarify comment in room palette handling code


Commit: cb5436dd16653b01fa5834f573b0aa6954744a30
    https://github.com/scummvm/scummvm/commit/cb5436dd16653b01fa5834f573b0aa6954744a30
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2018-01-31T18:37:24+01:00

Commit Message:
TUCKER: Clarify comment in room palette handling code

Changed paths:
    engines/tucker/locations.cpp


diff --git a/engines/tucker/locations.cpp b/engines/tucker/locations.cpp
index e337279..1a72790 100644
--- a/engines/tucker/locations.cpp
+++ b/engines/tucker/locations.cpp
@@ -1791,8 +1791,9 @@ void TuckerEngine::execData3PreUpdate_locationNum29() {
 		const int d = _updateLocationFadePaletteCounter / 2;
 		uint8 scrollPal[5 * 3];
 		for (int i = 0; i < 5; ++i) {
-			// TODO: Why is this needed? 6-bit colors?
 			// Bug Trac#6378. Shift the palette two bits to the left.
+			// The original was writing to 0x3C8-0x3c9 VGA registers which are
+			// 6-bit
 			scrollPal[i * 3 + 0] = r[i + d] << 2;
 			scrollPal[i * 3 + 1] = g[i + d] << 2;
 			scrollPal[i * 3 + 2] = b[i + d] << 2;





More information about the Scummvm-git-logs mailing list