[Scummvm-git-logs] scummvm master -> 31e8cb168e1664d254a18abe3b37ab95d78156d4

sev- sev at scummvm.org
Sat Jul 7 16:42:27 CEST 2018


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
31e8cb168e CONFIGURE: Do not add -Wno-pragma-pack on macOS


Commit: 31e8cb168e1664d254a18abe3b37ab95d78156d4
    https://github.com/scummvm/scummvm/commit/31e8cb168e1664d254a18abe3b37ab95d78156d4
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2018-07-07T16:41:38+02:00

Commit Message:
CONFIGURE: Do not add -Wno-pragma-pack on macOS

macOS' clang does not support this directive (yet), which
leads to tons of useless warnings

Changed paths:
    configure


diff --git a/configure b/configure
index 26b8958..fdc0706 100755
--- a/configure
+++ b/configure
@@ -1921,7 +1921,17 @@ if test "$have_clang" = yes; then
 	# which changes the current alignment.
 	# Our common/pack-{start,end}.h trigger this and it cannot easily and portably
 	# be disabled inside pack-{start,end}.h so we disable it globally for now.
-	test "$_clang_major" -ge 6 && append_var CXXFLAGS "-Wno-pragma-pack"
+
+	# But macOS clang is numbered according to the OS version, so exclude it
+
+	case $_host_os in
+		darwin*)
+			# Leave it as is
+		;;
+		*)
+			test "$_clang_major" -ge 6 append_var CXXFLAGS "-Wno-pragma-pack"
+		;;
+	esac
 
 	# clang does accept all gcc options we use, so we keep have_gcc
 fi





More information about the Scummvm-git-logs mailing list