[Scummvm-git-logs] scummvm master -> 9831f6ddd293202984d5d421f24d0078406ef9af

[digitall]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
9831f6ddd2 GUI: Disable Current View Selection Button in Save/Load Chooser.


Commit: 9831f6ddd293202984d5d421f24d0078406ef9af
    https://github.com/scummvm/scummvm/commit/9831f6ddd293202984d5d421f24d0078406ef9af
Author: D G Turner (digitall at scummvm.org)
Date: 2018-10-10T08:20:17+01:00

Commit Message:
GUI: Disable Current View Selection Button in Save/Load Chooser.

Switching between List and Grid views causes a nasty redraw flicker.
This also occurs if you press the button for the current view type.

This patch does not fix the underlying refresh issue, but it does
disable the button for the current view type as pressing this is not
useful in any case.

This is a partial fix for bug Trac #10441.

Changed paths:
    gui/saveload-dialog.cpp


diff --git a/gui/saveload-dialog.cpp b/gui/saveload-dialog.cpp
index 2702cbe..d0132d9 100644
--- a/gui/saveload-dialog.cpp
+++ b/gui/saveload-dialog.cpp
@@ -264,11 +264,17 @@ void SaveLoadChooserDialog::handleTickle() {
 
 void SaveLoadChooserDialog::reflowLayout() {
 #ifndef DISABLE_SAVELOADCHOOSER_GRID
-	addChooserButtons();
-
 	const SaveLoadChooserType currentType = getType();
 	const SaveLoadChooserType requestedType = getRequestedSaveLoadDialog(*_metaEngine);
 
+	addChooserButtons();
+	if (currentType == kSaveLoadDialogList) {
+		_listButton->setEnabled(false);
+	}
+	if (currentType == kSaveLoadDialogGrid) {
+		_gridButton->setEnabled(false);
+	}
+
 	// Change the dialog type if there is any need for it.
 	if (requestedType != currentType) {
 		setResult(kSwitchSaveLoadDialog);