[Scummvm-git-logs] scummvm master -> 209c62201028ffa546d1ac4b269bcf7fb6514b0b

bluegr bluegr at gmail.com
Mon Oct 22 23:41:02 CEST 2018


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
209c622010 SCI: GK1 workaround for iconbar uninit param read


Commit: 209c62201028ffa546d1ac4b269bcf7fb6514b0b
    https://github.com/scummvm/scummvm/commit/209c62201028ffa546d1ac4b269bcf7fb6514b0b
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2018-10-23T00:12:03+03:00

Commit Message:
SCI: GK1 workaround for iconbar uninit param read

Uninitialized param1 read when showing iconbar with inventory item

Changed paths:
    engines/sci/engine/workarounds.cpp


diff --git a/engines/sci/engine/workarounds.cpp b/engines/sci/engine/workarounds.cpp
index 05a6742..af96b14 100644
--- a/engines/sci/engine/workarounds.cpp
+++ b/engines/sci/engine/workarounds.cpp
@@ -322,6 +322,7 @@ static const uint16 sig_uninitread_sq1_1[] = {
 // Workarounds for uninitialized reads for parameters
 //    gameID,           room,script,lvl,          object-name, method-name,       local-call-signature, index-range,  workaround
 const SciWorkaroundEntry uninitializedReadForParamWorkarounds[] = {
+	{ GID_GK1,            -1,    12, -1,          "GKIconbar", "showInvItem",                     NULL,     1,     1,{ WORKAROUND_FAKE,   0 } }, // When showing the icon bar containing an inventory item
 	{ GID_HOYLE5,         -1,    15, -1,               "Hand", "add",                             NULL,     1,     1,{ WORKAROUND_FAKE,   0 } }, // When the game adds cards to your hand in any mini-game
 	{ GID_HOYLE5,        700,   730,  0,                 NULL, "runningSuit",                     NULL,     2,     2,{ WORKAROUND_FAKE,   0 } }, // when an opponent is playing in Bridge
 	{ GID_HOYLE5,       1100,    22, -1,           "HandPile", "show",                            NULL,     1,     1,{ WORKAROUND_FAKE,   0 } }, // when showing money piles in Poker





More information about the Scummvm-git-logs mailing list