[Scummvm-git-logs] scummvm master -> 3f21fff11140f01ae80d487f0c10d1e2647ac5dd

[digitall]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3f21fff111 KYRA: Fix Urbish Mines Lobster Monster Crash in LOL.


Commit: 3f21fff11140f01ae80d487f0c10d1e2647ac5dd
    https://github.com/scummvm/scummvm/commit/3f21fff11140f01ae80d487f0c10d1e2647ac5dd
Author: D G Turner (digitall at scummvm.org)
Date: 2018-10-25T18:33:17+01:00

Commit Message:
KYRA: Fix Urbish Mines Lobster Monster Crash in LOL.

This occurs because of an out of buffer access when trying to play the
monster sound effect.

This is bug Trac #10665.

Changed paths:
    engines/kyra/sound_lol.cpp


diff --git a/engines/kyra/sound_lol.cpp b/engines/kyra/sound_lol.cpp
index 51239bc..ec48dc8 100644
--- a/engines/kyra/sound_lol.cpp
+++ b/engines/kyra/sound_lol.cpp
@@ -161,7 +161,7 @@ void LoLEngine::snd_playSoundEffect(int track, int volume) {
 		return;
 
 	_lastSfxTrack = track;
-	if (track == -1 || track >= _ingameSoundIndexSize)
+	if (track == -1 || track >= (_ingameSoundIndexSize - 500) / 2)
 		return;
 
 	volume &= 0xFF;