[Scummvm-git-logs] scummvm master -> 9052a16887f21190865812cbe887b250d91074ae

ccawley2011 ccawley2011 at gmail.com
Sat Aug 10 15:50:59 CEST 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
9052a16887 GRAPHICS: MACGUI: Use Common::String for addMenuItem and addMenuSubItem


Commit: 9052a16887f21190865812cbe887b250d91074ae
    https://github.com/scummvm/scummvm/commit/9052a16887f21190865812cbe887b250d91074ae
Author: Cameron Cawley (ccawley2011 at gmail.com)
Date: 2019-08-10T14:50:33+01:00

Commit Message:
GRAPHICS: MACGUI: Use Common::String for addMenuItem and addMenuSubItem

Changed paths:
    engines/wage/gui.cpp
    graphics/macgui/macmenu.cpp
    graphics/macgui/macmenu.h


diff --git a/engines/wage/gui.cpp b/engines/wage/gui.cpp
index 9c76418..6075ee1 100644
--- a/engines/wage/gui.cpp
+++ b/engines/wage/gui.cpp
@@ -102,11 +102,11 @@ Gui::Gui(WageEngine *engine) {
 	_menu->addStaticMenus(menuSubItems);
 	_menu->addMenuSubItem(kMenuAbout, _engine->_world->getAboutMenuItemName(), kMenuActionAbout);
 
-	_commandsMenuId = _menu->addMenuItem(_engine->_world->_commandsMenuName.c_str());
+	_commandsMenuId = _menu->addMenuItem(_engine->_world->_commandsMenuName);
 	regenCommandsMenu();
 
 	if (!_engine->_world->_weaponMenuDisabled) {
-		_weaponsMenuId = _menu->addMenuItem(_engine->_world->_weaponsMenuName.c_str());
+		_weaponsMenuId = _menu->addMenuItem(_engine->_world->_weaponsMenuName);
 
 		regenWeaponsMenu();
 	} else {
@@ -226,7 +226,7 @@ void Gui::regenWeaponsMenu() {
 			command += " ";
 			command += obj->_name;
 
-			_menu->addMenuSubItem(_weaponsMenuId, command.c_str(), kMenuActionCommand, 0, 0, true);
+			_menu->addMenuSubItem(_weaponsMenuId, command, kMenuActionCommand, 0, 0, true);
 
 			empty = false;
 		}
diff --git a/graphics/macgui/macmenu.cpp b/graphics/macgui/macmenu.cpp
index 97ad2a6..a966f98 100644
--- a/graphics/macgui/macmenu.cpp
+++ b/graphics/macgui/macmenu.cpp
@@ -75,7 +75,7 @@ struct MacMenuSubItem {
 	bool enabled;
 	Common::Rect bbox;
 
-	MacMenuSubItem(const char *t, int a, int s = 0, char sh = 0, bool e = true) : text(t), unicode(false), action(a), style(s), shortcut(sh), enabled(e) {}
+	MacMenuSubItem(const Common::String &t, int a, int s = 0, char sh = 0, bool e = true) : text(t), unicode(false), action(a), style(s), shortcut(sh), enabled(e) {}
 	MacMenuSubItem(const Common::U32String &t, int a, int s = 0, char sh = 0, bool e = true) : unicodeText(t), unicode(true), action(a), style(s), shortcut(sh), enabled(e) {}
 };
 
@@ -89,7 +89,7 @@ struct MacMenuItem {
 	Common::Rect bbox;
 	Common::Rect subbbox;
 
-	MacMenuItem(const char *n) : name(n), unicode(false) {}
+	MacMenuItem(const Common::String &n) : name(n), unicode(false) {}
 	MacMenuItem(const Common::U32String &n) : unicodeName(n), unicode(true) {}
 };
 
@@ -260,7 +260,7 @@ void MacMenu::addStaticMenus(const MacMenuData *data) {
 	calcDimensions();
 }
 
-int MacMenu::addMenuItem(const char *name) {
+int MacMenu::addMenuItem(const Common::String &name) {
 	MacMenuItem *i = new MacMenuItem(name);
 	_items.push_back(i);
 
@@ -274,7 +274,7 @@ int MacMenu::addMenuItem(const Common::U32String &name) {
 	return _items.size() - 1;
 }
 
-void MacMenu::addMenuSubItem(int id, const char *text, int action, int style, char shortcut, bool enabled) {
+void MacMenu::addMenuSubItem(int id, const Common::String &text, int action, int style, char shortcut, bool enabled) {
 	_items[id]->subitems.push_back(new MacMenuSubItem(text, action, style, shortcut, enabled));
 
 	calcMenuBounds(_items[id]);
@@ -378,7 +378,7 @@ void MacMenu::createSubMenuFromString(int id, const char *str, int commandId) {
 					}
 			}
 
-			menu->subitems.push_back(new MacMenuSubItem(item.c_str(), commandId, style, shortcut, enabled));
+			menu->subitems.push_back(new MacMenuSubItem(item, commandId, style, shortcut, enabled));
 		}
 
 		item.clear();
diff --git a/graphics/macgui/macmenu.h b/graphics/macgui/macmenu.h
index 717a0ce..388e662 100644
--- a/graphics/macgui/macmenu.h
+++ b/graphics/macgui/macmenu.h
@@ -57,9 +57,9 @@ public:
 	void addStaticMenus(const MacMenuData *data);
 	void calcDimensions();
 
-	int addMenuItem(const char *name);
+	int addMenuItem(const Common::String &name);
 	int addMenuItem(const Common::U32String &name);
-	void addMenuSubItem(int id, const char *text, int action, int style = 0, char shortcut = 0, bool enabled = true);
+	void addMenuSubItem(int id, const Common::String &text, int action, int style = 0, char shortcut = 0, bool enabled = true);
 	void addMenuSubItem(int id, const Common::U32String &text, int action, int style = 0, char shortcut = 0, bool enabled = true);
 	void createSubMenuFromString(int id, const char *string, int commandId);
 	void clearSubMenu(int id);





More information about the Scummvm-git-logs mailing list