[Scummvm-git-logs] scummvm master -> 538bb7ab3e2ce73ef57833859455ceb76467ce54

digitall 547637+digitall at users.noreply.github.com
Sun Dec 1 01:25:01 UTC 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
538bb7ab3e SHERLOCK: Fix Missing Default Switch Cases


Commit: 538bb7ab3e2ce73ef57833859455ceb76467ce54
    https://github.com/scummvm/scummvm/commit/538bb7ab3e2ce73ef57833859455ceb76467ce54
Author: D G Turner (digitall at scummvm.org)
Date: 2019-12-01T01:21:09Z

Commit Message:
SHERLOCK: Fix Missing Default Switch Cases

These are flagged by GCC if -Wswitch-default is enabled.

Changed paths:
    engines/sherlock/objects.cpp
    engines/sherlock/scalpel/scalpel_people.cpp
    engines/sherlock/scalpel/scalpel_user_interface.cpp
    engines/sherlock/tattoo/tattoo_people.cpp
    engines/sherlock/tattoo/tattoo_user_interface.cpp


diff --git a/engines/sherlock/objects.cpp b/engines/sherlock/objects.cpp
index c7eee36..6acb8da 100644
--- a/engines/sherlock/objects.cpp
+++ b/engines/sherlock/objects.cpp
@@ -130,6 +130,7 @@ bool BaseObject::hasAborts() const {
 			case TELEPORT_CODE:	idx += 4; break;
 			case CALL_TALK_CODE:idx += 8; break;
 			case HIDE_CODE:		idx += 2; break;
+			default: break;
 			}
 		}
 	} while (idx < _seqSize);
@@ -1281,6 +1282,7 @@ void Object::setObjTalkSequence(int seq) {
 			case TELEPORT_CODE: idx += 4; break;
 			case CALL_TALK_CODE: idx += 8; break;
 			case HIDE_CODE: idx += 2; break;
+			default: break;
 			}
 		}
 
diff --git a/engines/sherlock/scalpel/scalpel_people.cpp b/engines/sherlock/scalpel/scalpel_people.cpp
index 924095c..8b71f53 100644
--- a/engines/sherlock/scalpel/scalpel_people.cpp
+++ b/engines/sherlock/scalpel/scalpel_people.cpp
@@ -275,6 +275,8 @@ void ScalpelPerson::setWalking() {
 					case WALK_RIGHT:
 						_sequenceNumber = WALK_DOWNRIGHT;
 						break;
+					default:
+						break;
 					}
 				}
 			} else if (_delta.y < -150) {
@@ -286,6 +288,8 @@ void ScalpelPerson::setWalking() {
 					case WALK_RIGHT:
 						_sequenceNumber = WALK_UPRIGHT;
 						break;
+					default:
+						break;
 					}
 				}
 			}
diff --git a/engines/sherlock/scalpel/scalpel_user_interface.cpp b/engines/sherlock/scalpel/scalpel_user_interface.cpp
index 8f0ebbf..b39ccbe 100644
--- a/engines/sherlock/scalpel/scalpel_user_interface.cpp
+++ b/engines/sherlock/scalpel/scalpel_user_interface.cpp
@@ -1738,6 +1738,8 @@ void ScalpelUserInterface::doTalkControl() {
 			case 3:
 				people._portraitSide = 120;
 				break;
+			default:
+				break;
 			}
 
 			// Check for flipping Holmes
diff --git a/engines/sherlock/tattoo/tattoo_people.cpp b/engines/sherlock/tattoo/tattoo_people.cpp
index 458cc1a..0eecfe0 100644
--- a/engines/sherlock/tattoo/tattoo_people.cpp
+++ b/engines/sherlock/tattoo/tattoo_people.cpp
@@ -314,6 +314,7 @@ void TattooPerson::gotoStand() {
 		case WALK_DOWNLEFT: _sequenceNumber = STOP_DOWNLEFT;break;
 		case WALK_LEFT: _sequenceNumber = STOP_LEFT;		break;
 		case WALK_UPLEFT: _sequenceNumber = STOP_UPLEFT;	break;
+		default: break;
 		}
 	}
 
@@ -439,6 +440,8 @@ void TattooPerson::setWalking() {
 				case WALK_RIGHT:
 					_sequenceNumber = WALK_DOWNRIGHT;
 					break;
+				default:
+					break;
 				}
 			} else if (_delta.y < -1500) {
 				if (_sequenceNumber == WALK_LEFT || _sequenceNumber == WALK_RIGHT) {
@@ -455,6 +458,8 @@ void TattooPerson::setWalking() {
 				case WALK_RIGHT:
 					_sequenceNumber = WALK_UPRIGHT;
 					break;
+				default:
+					break;
 				}
 			}
 		} else {
@@ -773,6 +778,8 @@ void TattooPerson::updateNPC() {
 						case NPCPATH_IFFLAG_GOTO_LABEL:
 							_npcIndex += 4;
 							break;
+						default:
+							break;
 						}
 					}
 					break;
@@ -819,6 +826,8 @@ void TattooPerson::updateNPC() {
 							case NPCPATH_IFFLAG_GOTO_LABEL:
 								_npcIndex += 4;
 								break;
+							default:
+								break;
 							}
 						}
 					}
diff --git a/engines/sherlock/tattoo/tattoo_user_interface.cpp b/engines/sherlock/tattoo/tattoo_user_interface.cpp
index 1cb0220..2b7b7fb 100644
--- a/engines/sherlock/tattoo/tattoo_user_interface.cpp
+++ b/engines/sherlock/tattoo/tattoo_user_interface.cpp
@@ -857,6 +857,9 @@ void TattooUserInterface::drawMaskArea(bool mode) {
 			maskArea(*_mask, Common::Point(xp, 203));
 			maskArea(*_mask1, Common::Point(124 + xp, 239));
 			break;
+
+		default:
+			break;
 		}
 	}
 }




More information about the Scummvm-git-logs mailing list