[Scummvm-git-logs] scummvm master -> 448adc81d379177e99693ebbbd39d2d3d79db1ac
eriktorbjorn
eriktorbjorn at telia.com
Fri Jan 4 13:30:21 CET 2019
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
448adc81d3 GLK: FROTZ: Clarify comment about Unicode runes a bit.
Commit: 448adc81d379177e99693ebbbd39d2d3d79db1ac
https://github.com/scummvm/scummvm/commit/448adc81d379177e99693ebbbd39d2d3d79db1ac
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2019-01-04T13:29:42+01:00
Commit Message:
GLK: FROTZ: Clarify comment about Unicode runes a bit.
This started out as a typo fix. :-)
Changed paths:
engines/glk/frotz/processor_screen.cpp
diff --git a/engines/glk/frotz/processor_screen.cpp b/engines/glk/frotz/processor_screen.cpp
index da45fa1..dcde4b0 100644
--- a/engines/glk/frotz/processor_screen.cpp
+++ b/engines/glk/frotz/processor_screen.cpp
@@ -82,11 +82,13 @@ uint32 Processor::zchar_to_unicode_rune(zchar c) {
// This produced an ugly mix of runes and map-drawing characters, etc.
// which is probably why it was removed in later versions.
//
- // Apart from the runes, I believe the up/down arrows are the only
- // special characters to be printed in the lower window. Maybe they,
- // too, should be mapped to Unicode characters, but since they are
- // mapped to \ and ] respectively that probably menas we can convert
- // upper case to lower case and use the appropriate rune for that.
+ // Still, it's probably a good idea to convert the upper case letters
+ // to lower case to get an appropriate rune. As far as I can tell, the
+ // upper case letters are all used for drawing maps and progress bars.
+ // I don't think they're ever intended for the lower window.
+ //
+ // Apart from the runes, the arrow glyphs could perhaps also be
+ // sensibly converted to Unicode?
if (c >= 'a' && c <= 'z')
return zchar_runes[c - 'a'];
else if (c >= 'A' && c <= 'Z')
More information about the Scummvm-git-logs
mailing list