[Scummvm-git-logs] scummvm master -> 7394afbbc80be994cea0a83a91fadaf9aeccffdd

eriktorbjorn eriktorbjorn at telia.com
Fri Jan 4 14:48:17 CET 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
7394afbbc8 GLK: Fix negative index crash when clicking in a window


Commit: 7394afbbc80be994cea0a83a91fadaf9aeccffdd
    https://github.com/scummvm/scummvm/commit/7394afbbc80be994cea0a83a91fadaf9aeccffdd
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2019-01-04T14:47:36+01:00

Commit Message:
GLK: Fix negative index crash when clicking in a window

Changed paths:
    engines/glk/window_pair.cpp


diff --git a/engines/glk/window_pair.cpp b/engines/glk/window_pair.cpp
index 7ddd57b..d571dc5 100644
--- a/engines/glk/window_pair.cpp
+++ b/engines/glk/window_pair.cpp
@@ -245,7 +245,7 @@ void PairWindow::setArrangement(uint method, uint size, Window *keyWin) {
 }
 
 void PairWindow::click(const Point &newPos) {
-	for (int ctr = 0, idx = (!_backward ? (int)_children.size() - 1 : 0); ctr < (int)_children.size();
+	for (int ctr = 0, idx = (_backward ? (int)_children.size() - 1 : 0); ctr < (int)_children.size();
 		++ctr, idx += (_backward ? -1 : 1)) {
 		Window *w = _children[idx];
 		if (w->_bbox.contains(newPos))





More information about the Scummvm-git-logs mailing list