[Scummvm-git-logs] scummvm master -> 535a15f25ab5f18f2abd11cd90b089c5de9a9ba2

athrxx mail at floriankagerer.de
Sun Jan 20 14:41:57 CET 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
535a15f25a KYRA: fix GMM save/load invalid mem access for very old savegames


Commit: 535a15f25ab5f18f2abd11cd90b089c5de9a9ba2
    https://github.com/scummvm/scummvm/commit/535a15f25ab5f18f2abd11cd90b089c5de9a9ba2
Author: athrxx (athrxx at scummvm.org)
Date: 2019-01-20T14:39:42+01:00

Commit Message:
KYRA: fix GMM save/load invalid mem access for very old savegames

This is for save files created 2006, 2007 and early 2008. Which is probably the reason why this has gone unnoticed.

Changed paths:
    engines/kyra/saveload.cpp


diff --git a/engines/kyra/saveload.cpp b/engines/kyra/saveload.cpp
index e59eb5d..09d222a 100644
--- a/engines/kyra/saveload.cpp
+++ b/engines/kyra/saveload.cpp
@@ -128,6 +128,8 @@ WARN_UNUSED_RESULT KyraEngine_v1::ReadSaveHeaderError KyraEngine_v1::readSaveHea
 			if (!skipThumbnail)
 				return kRSHEIoError;
 		}
+	} else {
+		header.thumbnail = 0;
 	}
 
 	return ((in->err() || in->eos()) ? kRSHEIoError : kRSHENoError);





More information about the Scummvm-git-logs mailing list