[Scummvm-git-logs] scummvm master -> e65bfad30e6fefb71087633c380c368b965620d6

antoniou79 antoniou at cti.gr
Mon Jun 3 20:28:59 CEST 2019


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
70c2d3980d BLADERUNNER: Fix exit 0 in BB01 and remove more awry clickables
e65bfad30e BLADERUNNER: Restore Gordo's lighter (Rep) comment


Commit: 70c2d3980d08c69869c1afba96ae9a12daa125b6
    https://github.com/scummvm/scummvm/commit/70c2d3980d08c69869c1afba96ae9a12daa125b6
Author: Thanasis Antoniou (a.antoniou79 at gmail.com)
Date: 2019-06-03T21:24:56+03:00

Commit Message:
BLADERUNNER: Fix exit 0 in BB01 and remove more awry clickables

Changed paths:
    engines/bladerunner/script/scene/bb01.cpp
    engines/bladerunner/script/scene/ct10.cpp
    engines/bladerunner/script/scene/ug09.cpp
    engines/bladerunner/script/scene/ug15.cpp


diff --git a/engines/bladerunner/script/scene/bb01.cpp b/engines/bladerunner/script/scene/bb01.cpp
index 488022d..fff17e7 100644
--- a/engines/bladerunner/script/scene/bb01.cpp
+++ b/engines/bladerunner/script/scene/bb01.cpp
@@ -41,11 +41,22 @@ void SceneScriptBB01::InitializeScene() {
 		Setup_Scene_Information(  43.0f, 0.0f, 1058.0f,   0);
 	}
 
+#if BLADERUNNER_ORIGINAL_BUGS
 	Scene_Exit_Add_2D_Exit(0,   0,   0,  72, 299, 3);
 	Scene_Exit_Add_2D_Exit(1, 151, 218, 322, 290, 3);
 	if (Game_Flag_Query(kFlagSpinnerAtBB01)) {
 		Scene_Exit_Add_2D_Exit(2, 0, 311, 312, 479, 2);
 	}
+#else
+	// expand the left exit downwards as much as possible, especially if Spinner is missing
+	Scene_Exit_Add_2D_Exit(1, 151, 218, 322, 290, 3);
+	if (Game_Flag_Query(kFlagSpinnerAtBB01)) {
+		Scene_Exit_Add_2D_Exit(0, 0,   0,  72, 311, 3);
+		Scene_Exit_Add_2D_Exit(2, 0, 311, 312, 479, 2);
+	} else {
+		Scene_Exit_Add_2D_Exit(0, 0,   0,  72, 400, 3);
+	}
+#endif // BLADERUNNER_ORIGINAL_BUGS
 
 	Ambient_Sounds_Add_Looping_Sound(kSfxCTRAIN1,  50,    0, 1);
 	Ambient_Sounds_Add_Looping_Sound(kSfxCTRUNOFF, 25, -100, 0);
diff --git a/engines/bladerunner/script/scene/ct10.cpp b/engines/bladerunner/script/scene/ct10.cpp
index 1b54837..2a577bf 100644
--- a/engines/bladerunner/script/scene/ct10.cpp
+++ b/engines/bladerunner/script/scene/ct10.cpp
@@ -57,6 +57,10 @@ void SceneScriptCT10::SceneLoaded() {
 	Clickable_Object("CABINETFRONT");
 	Clickable_Object("CABINETTOP");
 	Clickable_Object("TUB");
+#if BLADERUNNER_ORIGINAL_BUGS
+#else
+	Unclickable_Object("BED");
+#endif // BLADERUNNER_ORIGINAL_BUGS
 	Scene_2D_Region_Add(0, 379, 229, 454, 375);
 }
 
diff --git a/engines/bladerunner/script/scene/ug09.cpp b/engines/bladerunner/script/scene/ug09.cpp
index 4bf94b7..d178d6a 100644
--- a/engines/bladerunner/script/scene/ug09.cpp
+++ b/engines/bladerunner/script/scene/ug09.cpp
@@ -82,6 +82,10 @@ void SceneScriptUG09::SceneLoaded() {
 	Unobstacle_Object("BOX34", true);
 	Unobstacle_Object("BOX32", true);
 	Clickable_Object("FACADE_CANOPY");
+#if BLADERUNNER_ORIGINAL_BUGS
+#else
+	Unclickable_Object("FACADE_CANOPY");
+#endif // BLADERUNNER_ORIGINAL_BUGS
 }
 
 bool SceneScriptUG09::MouseClick(int x, int y) {
diff --git a/engines/bladerunner/script/scene/ug15.cpp b/engines/bladerunner/script/scene/ug15.cpp
index 62ae01b..62fa14f 100644
--- a/engines/bladerunner/script/scene/ug15.cpp
+++ b/engines/bladerunner/script/scene/ug15.cpp
@@ -96,6 +96,10 @@ void SceneScriptUG15::SceneLoaded() {
 	Unobstacle_Object("LOFT01", true);
 	Obstacle_Object("NUT1", true);
 	Clickable_Object("NUT1");
+#if BLADERUNNER_ORIGINAL_BUGS
+#else
+	Unclickable_Object("NUT1");
+#endif // BLADERUNNER_ORIGINAL_BUGS
 }
 
 bool SceneScriptUG15::MouseClick(int x, int y) {


Commit: e65bfad30e6fefb71087633c380c368b965620d6
    https://github.com/scummvm/scummvm/commit/e65bfad30e6fefb71087633c380c368b965620d6
Author: Thanasis Antoniou (a.antoniou79 at gmail.com)
Date: 2019-06-03T21:24:56+03:00

Commit Message:
BLADERUNNER: Restore Gordo's lighter (Rep) comment

Changed paths:
    engines/bladerunner/game_constants.h
    engines/bladerunner/script/ai/gaff.cpp
    engines/bladerunner/script/ai/gordo.cpp
    engines/bladerunner/script/ai/mccoy.cpp
    engines/bladerunner/script/init_script.cpp
    engines/bladerunner/script/kia_script.cpp
    engines/bladerunner/script/scene/ct06.cpp
    engines/bladerunner/script/scene/ct12.cpp


diff --git a/engines/bladerunner/game_constants.h b/engines/bladerunner/game_constants.h
index 12f33b7..5b7877f 100644
--- a/engines/bladerunner/game_constants.h
+++ b/engines/bladerunner/game_constants.h
@@ -123,7 +123,7 @@ enum Clues {
 	kClueCrowdInterviewB = 17,
 	kClueZubenRunsAway = 18,
 	kClueZubenInterview = 19,
-	kClueZuben = 20,
+	kClueZubenSquadPhoto = 20,
 	kClueBigManLimping = 21,
 	kClueRunciterInterviewA = 22,
 	kClueRunciterInterviewB1 = 23,
diff --git a/engines/bladerunner/script/ai/gaff.cpp b/engines/bladerunner/script/ai/gaff.cpp
index ac9d944..dbe6899 100644
--- a/engines/bladerunner/script/ai/gaff.cpp
+++ b/engines/bladerunner/script/ai/gaff.cpp
@@ -94,7 +94,7 @@ void AIScriptGaff::CompletedMovementTrack() {
 		Actor_Says(kActorGaff, 40, kAnimationModeTalk);
 		Actor_Says(kActorMcCoy, 690, kAnimationModeTalk);
 		Actor_Clue_Acquire(kActorMcCoy, kClueGaffsInformation, true, kActorGaff);
-		CDB_Set_Crime(kClueZuben, kCrimeMoonbusHijacking);
+		CDB_Set_Crime(kClueZubenSquadPhoto, kCrimeMoonbusHijacking);
 		Actor_Clue_Acquire(kActorGaff, kClueMcCoyRetiredZuben, true, -1);
 		Game_Flag_Set(kFlagGaffApproachedMcCoyAboutZuben);
 		Player_Gains_Control();
diff --git a/engines/bladerunner/script/ai/gordo.cpp b/engines/bladerunner/script/ai/gordo.cpp
index 11afe3e..2ebac44 100644
--- a/engines/bladerunner/script/ai/gordo.cpp
+++ b/engines/bladerunner/script/ai/gordo.cpp
@@ -1700,7 +1700,7 @@ void AIScriptGordo::dialogue2() {
 	} else if (answer == 830) { // LET GO
 		Actor_Says(kActorMcCoy, 3100, 16);
 		Actor_Says(kActorGordo, 240, 14);
-		if (Actor_Clue_Query(0, 102)) {
+		if (Actor_Clue_Query(kActorMcCoy, kClueStolenCheese)) {
 			Actor_Says(kActorMcCoy, 3105, 15);
 			Actor_Says(kActorMcCoy, 3110, 17);
 			Actor_Says(kActorGordo, 250, 13);
diff --git a/engines/bladerunner/script/ai/mccoy.cpp b/engines/bladerunner/script/ai/mccoy.cpp
index 070c3f2..e39d0f8 100644
--- a/engines/bladerunner/script/ai/mccoy.cpp
+++ b/engines/bladerunner/script/ai/mccoy.cpp
@@ -246,10 +246,12 @@ void AIScriptMcCoy::ReceivedClue(int clueId, int fromActorId) {
 		Actor_Clue_Acquire(kActorMcCoy, kClueGuzzaFramedMcCoy, true, -1);
 
 		if (clueId == kClueFolder) {
+			// if McCoy just got the folder
 			Actor_Voice_Over(2780, kActorVoiceOver);
 			Actor_Voice_Over(2800, kActorVoiceOver);
 			Actor_Voice_Over(2810, kActorVoiceOver);
 		} else if (Actor_Clue_Query(kActorMcCoy, kClueFolder)) {
+			// if McCoy already had the folder
 			Actor_Voice_Over(3430, kActorVoiceOver);
 			Actor_Voice_Over(3440, kActorVoiceOver);
 			Actor_Voice_Over(3450, kActorVoiceOver);
@@ -259,6 +261,7 @@ void AIScriptMcCoy::ReceivedClue(int clueId, int fromActorId) {
 			Actor_Voice_Over(3490, kActorVoiceOver);
 			Actor_Voice_Over(3500, kActorVoiceOver);
 		} else {
+			// if McCoy never got the folder
 			Actor_Voice_Over(3510, kActorVoiceOver);
 			Actor_Voice_Over(3520, kActorVoiceOver);
 			Actor_Voice_Over(3530, kActorVoiceOver);
diff --git a/engines/bladerunner/script/init_script.cpp b/engines/bladerunner/script/init_script.cpp
index 32ad965..db31ef6 100644
--- a/engines/bladerunner/script/init_script.cpp
+++ b/engines/bladerunner/script/init_script.cpp
@@ -2288,7 +2288,7 @@ void InitScript::Init_SDB() {
 	}
 	SDB_Add_Replicant_Clue(kSuspectZuben, kClueHowieLeeInterview);
 	SDB_Add_Replicant_Clue(kSuspectZuben, kClueZubenRunsAway);
-	SDB_Add_Replicant_Clue(kSuspectZuben, kClueZuben);
+	SDB_Add_Replicant_Clue(kSuspectZuben, kClueZubenSquadPhoto);
 	SDB_Add_Replicant_Clue(kSuspectZuben, kClueZubenTalksAboutLucy1);
 	SDB_Add_Replicant_Clue(kSuspectZuben, kClueZubenTalksAboutLucy2);
 	SDB_Add_Non_Replicant_Clue(kSuspectZuben, kClueLimpingFootprints);
@@ -2301,7 +2301,7 @@ void InitScript::Init_SDB() {
 	SDB_Add_Identity_Clue(kSuspectZuben, kClueZubenRunsAway);
 	SDB_Add_Identity_Clue(kSuspectZuben, kClueZubenInterview);
 	SDB_Add_Identity_Clue(kSuspectZuben, kClueLucyInterview);
-	SDB_Add_Photo_Clue(kSuspectZuben, kClueZuben, 33);
+	SDB_Add_Photo_Clue(kSuspectZuben, kClueZubenSquadPhoto, 33);
 
 	SDB_Set_Actor(kSuspectLucy, kActorLucy);
 	SDB_Set_Sex(kSuspectLucy, 0);
@@ -2436,7 +2436,7 @@ void InitScript::Init_CDB() {
 	CDB_Set_Crime(kClueZubenInterview, kCrimeAnimalMurder);
 	CDB_Set_Crime(kClueLucy, kCrimeAnimalMurder);
 	CDB_Set_Crime(kClueDragonflyAnklet, kCrimeAnimalMurder);
-	CDB_Set_Crime(kClueZuben, kCrimeAnimalMurder);
+	CDB_Set_Crime(kClueZubenSquadPhoto, kCrimeAnimalMurder);
 
 	CDB_Set_Crime(kCluePhoneCallGuzza, kCrimeEisendullerMurder);
 	CDB_Set_Crime(kClueDragonflyEarring, kCrimeEisendullerMurder);
@@ -2514,7 +2514,7 @@ void InitScript::Init_CDB() {
 	CDB_Set_Clue_Asset_Type(kClueCrowdInterviewA, kClueTypeAudioRecording);
 	CDB_Set_Clue_Asset_Type(kClueCrowdInterviewB, kClueTypeAudioRecording);
 	CDB_Set_Clue_Asset_Type(kClueZubenInterview, kClueTypeAudioRecording);
-	CDB_Set_Clue_Asset_Type(kClueZuben, kClueTypePhotograph);
+	CDB_Set_Clue_Asset_Type(kClueZubenSquadPhoto, kClueTypePhotograph);
 	CDB_Set_Clue_Asset_Type(kClueBigManLimping, kClueTypeAudioRecording);
 	CDB_Set_Clue_Asset_Type(kClueRunciterInterviewA, kClueTypeAudioRecording);
 	CDB_Set_Clue_Asset_Type(kClueRunciterInterviewB1, kClueTypeAudioRecording);
diff --git a/engines/bladerunner/script/kia_script.cpp b/engines/bladerunner/script/kia_script.cpp
index 4475e86..961e86c 100644
--- a/engines/bladerunner/script/kia_script.cpp
+++ b/engines/bladerunner/script/kia_script.cpp
@@ -121,7 +121,7 @@ void KIAScript::SCRIPT_KIA_DLL_Play_Clue_Asset_Script(int notUsed, int clueId) {
 		KIA_Play_Actor_Dialogue(kActorMcCoy, 410);
 		KIA_Play_Actor_Dialogue(kActorZuben, 50);
 		break;
-	case kClueZuben:
+	case kClueZubenSquadPhoto:
 		KIA_Play_Photograph(33);
 		KIA_Play_Actor_Dialogue(kActorVoiceOver, 350);
 		break;
@@ -489,7 +489,17 @@ void KIAScript::SCRIPT_KIA_DLL_Play_Clue_Asset_Script(int notUsed, int clueId) {
 		break;
 	case kClueGordosLighterReplicant:
 		KIA_Play_Slice_Model(kModelAnimationGordosLighterReplicant);
-		KIA_Play_Actor_Dialogue(kActorVoiceOver, 350);
+		if (_vm->_cutContent) {
+			if (Actor_Clue_Query(kActorMcCoy, kClueZubenSquadPhoto)) {
+				KIA_Play_Actor_Dialogue(kActorVoiceOver, 1450);
+			} else {
+				KIA_Play_Actor_Dialogue(kActorVoiceOver, 350);
+			}
+			KIA_Play_Actor_Dialogue(kActorVoiceOver, 1460);
+			KIA_Play_Actor_Dialogue(kActorVoiceOver, 1470);
+		} else {
+			KIA_Play_Actor_Dialogue(kActorVoiceOver, 350);
+		}
 		break;
 	case kClueGordosLighterHuman:
 		KIA_Play_Slice_Model(kModelAnimationGordosLighterHuman);
diff --git a/engines/bladerunner/script/scene/ct06.cpp b/engines/bladerunner/script/scene/ct06.cpp
index bed2b59..1aab6c5 100644
--- a/engines/bladerunner/script/scene/ct06.cpp
+++ b/engines/bladerunner/script/scene/ct06.cpp
@@ -91,7 +91,7 @@ bool SceneScriptCT06::ClickedOnActor(int actorId) {
 		Loop_Actor_Walk_To_Actor(kActorMcCoy, kActorZuben, 24, true, false);
 		Actor_Face_Actor(kActorMcCoy, kActorZuben, true);
 		if (!Game_Flag_Query(kFlagCT06ZubenPhoto)) {
-			Actor_Clue_Acquire(kActorMcCoy, kClueZuben, true, -1);
+			Actor_Clue_Acquire(kActorMcCoy, kClueZubenSquadPhoto, true, -1);
 			Item_Pickup_Spin_Effect(kModelAnimationPhoto, 340, 369);
 			Actor_Voice_Over(350, kActorVoiceOver);
 			Actor_Voice_Over(360, kActorVoiceOver);
diff --git a/engines/bladerunner/script/scene/ct12.cpp b/engines/bladerunner/script/scene/ct12.cpp
index 8cd5210..e4abbcb 100644
--- a/engines/bladerunner/script/scene/ct12.cpp
+++ b/engines/bladerunner/script/scene/ct12.cpp
@@ -287,7 +287,7 @@ void SceneScriptCT12::PlayerWalkedIn() {
 		Actor_Says(kActorMcCoy, 690, kAnimationModeTalk);
 		Actor_Clue_Acquire(kActorMcCoy, kClueGaffsInformation, true, kActorGaff);
 		Game_Flag_Set(kFlagGaffApproachedMcCoyAboutZuben);
-		CDB_Set_Crime(kClueZuben, kCrimeMoonbusHijacking);
+		CDB_Set_Crime(kClueZubenSquadPhoto, kCrimeMoonbusHijacking);
 
 		if (Game_Flag_Query(kFlagGaffApproachedMcCoyAboutZuben)
 		 && Game_Flag_Query(kFlagZubenRetired)





More information about the Scummvm-git-logs mailing list