[Scummvm-git-logs] scummvm master -> 448bf3f4fba70faace65f2da2497f268a6f300b5

dreammaster paulfgilbert at gmail.com
Mon Jun 17 04:45:06 CEST 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
448bf3f4fb GLK: ADVSYS: Fix Coverity warnings


Commit: 448bf3f4fba70faace65f2da2497f268a6f300b5
    https://github.com/scummvm/scummvm/commit/448bf3f4fba70faace65f2da2497f268a6f300b5
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2019-06-16T19:44:55-07:00

Commit Message:
GLK: ADVSYS: Fix Coverity warnings

Changed paths:
    engines/glk/advsys/game.cpp
    engines/glk/advsys/glk_interface.h


diff --git a/engines/glk/advsys/game.cpp b/engines/glk/advsys/game.cpp
index 0465583..76aa495 100644
--- a/engines/glk/advsys/game.cpp
+++ b/engines/glk/advsys/game.cpp
@@ -28,8 +28,8 @@ namespace Glk {
 namespace AdvSys {
 
 void Decrypter::decrypt(byte *data, size_t size) {
-	for (size_t idx = 0; idx < size; ++idx)
-		*data++ = ~(*data + 30);
+	for (size_t idx = 0; idx < size; ++idx, ++data)
+		*data = ~(*data + 30);
 }
 
 /*--------------------------------------------------------------------------*/
diff --git a/engines/glk/advsys/glk_interface.h b/engines/glk/advsys/glk_interface.h
index 9e37207..ae6b7a3 100644
--- a/engines/glk/advsys/glk_interface.h
+++ b/engines/glk/advsys/glk_interface.h
@@ -65,7 +65,7 @@ public:
 	 * Constructor
 	 */
 	GlkInterface(OSystem *syst, const GlkGameDescription &gameDesc) : GlkAPI(syst, gameDesc),
-		_saveSlot(-1) {}
+		_window(nullptr), _saveSlot(-1) {}
 };
 
 } // End of namespace AdvSys





More information about the Scummvm-git-logs mailing list