[Scummvm-git-logs] scummvm master -> 9c8d425f64c440e833d09609b3033b57df229887

bluegr bluegr at gmail.com
Wed Mar 27 06:49:45 CET 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
9c8d425f64 SCI: Fix broken speech after starting in text mode


Commit: 9c8d425f64c440e833d09609b3033b57df229887
    https://github.com/scummvm/scummvm/commit/9c8d425f64c440e833d09609b3033b57df229887
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2019-03-27T07:49:42+02:00

Commit Message:
SCI: Fix broken speech after starting in text mode

Fixes bug #10924 where starting or restoring in text mode and then
changing to speech mode within a game results in muted speech.

This is a regression introduced between 1.9 and 2.0, probably as part
of the synchronization refactor that created GuestAdditions.

Changed paths:
    engines/sci/engine/guest_additions.cpp


diff --git a/engines/sci/engine/guest_additions.cpp b/engines/sci/engine/guest_additions.cpp
index d7e9870..afc87a5 100644
--- a/engines/sci/engine/guest_additions.cpp
+++ b/engines/sci/engine/guest_additions.cpp
@@ -919,6 +919,9 @@ void GuestAdditions::syncMessageTypeToScummVMUsingDefaultStrategy(const int inde
 
 		ConfMan.setBool("subtitles", value.toSint16() & kMessageTypeSubtitles);
 		ConfMan.setBool("speech_mute", !(value.toSint16() & kMessageTypeSpeech));
+
+		// need to update sound mixer volumes so that speech_mute will take effect
+		g_sci->updateSoundMixerVolumes();
 	}
 }
 





More information about the Scummvm-git-logs mailing list