[Scummvm-git-logs] scummvm branch-2-1 -> e40c551353de0f756f420566f81731007a418574

sluicebox 22204938+sluicebox at users.noreply.github.com
Thu Nov 7 13:42:10 CET 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
e40c551353 SCI32: Fix GK1 icon bar workaround


Commit: e40c551353de0f756f420566f81731007a418574
    https://github.com/scummvm/scummvm/commit/e40c551353de0f756f420566f81731007a418574
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2019-11-07T04:40:56-08:00

Commit Message:
SCI32: Fix GK1 icon bar workaround

Fixes an uninitialized parameter workaround, trac #11215

This caused the icon bar to error when in "icon up" mode

Changed paths:
    engines/sci/engine/workarounds.cpp


diff --git a/engines/sci/engine/workarounds.cpp b/engines/sci/engine/workarounds.cpp
index ea1d553..15519fb 100644
--- a/engines/sci/engine/workarounds.cpp
+++ b/engines/sci/engine/workarounds.cpp
@@ -332,7 +332,7 @@ static const uint16 sig_uninitread_sq1_1[] = {
 // Workarounds for uninitialized reads for parameters
 //    gameID,           room,script,lvl,          object-name, method-name,       local-call-signature, index-range,  workaround
 const SciWorkaroundEntry uninitializedReadForParamWorkarounds[] = {
-	{ GID_GK1,            -1,    12, -1,          "GKIconbar", "showInvItem",                     NULL,     1,     1,{ WORKAROUND_FAKE,   0 } }, // When showing the icon bar containing an inventory item
+	{ GID_GK1,            -1,    12, -1,          "GKIconbar", "showInvItem",                     NULL,     1,     1,{ WORKAROUND_FAKE,   1 } }, // When showing the icon bar containing an inventory item
 	{ GID_HOYLE5,         -1,    15, -1,               "Hand", "add",                             NULL,     1,     1,{ WORKAROUND_FAKE,   0 } }, // When the game adds cards to your hand in any mini-game
 	{ GID_HOYLE5,        700,   730,  0,                 NULL, "runningSuit",                     NULL,     2,     2,{ WORKAROUND_FAKE,   0 } }, // when an opponent is playing in Bridge
 	{ GID_HOYLE5,       1100,    22, -1,           "HandPile", "show",                            NULL,     1,     1,{ WORKAROUND_FAKE,   0 } }, // when showing money piles in Poker





More information about the Scummvm-git-logs mailing list