[Scummvm-git-logs] scummvm master -> f47a58ba64b1aa6dea32f76f6b060b6af87a0714

digitall 547637+digitall at users.noreply.github.com
Fri Oct 4 01:11:38 CEST 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f47a58ba64 CLOUD: Add Missing Default Switch Cases


Commit: f47a58ba64b1aa6dea32f76f6b060b6af87a0714
    https://github.com/scummvm/scummvm/commit/f47a58ba64b1aa6dea32f76f6b060b6af87a0714
Author: D G Turner (digitall at scummvm.org)
Date: 2019-10-04T00:08:14+01:00

Commit Message:
CLOUD: Add Missing Default Switch Cases

These are flagged by GCC if -Wswitch-default is enabled.

Changed paths:
    backends/cloud/cloudicon.cpp
    backends/cloud/cloudmanager.cpp


diff --git a/backends/cloud/cloudicon.cpp b/backends/cloud/cloudicon.cpp
index fcac856..708bd24 100644
--- a/backends/cloud/cloudicon.cpp
+++ b/backends/cloud/cloudicon.cpp
@@ -85,6 +85,8 @@ void CloudIcon::update() {
 	_lastUpdateTime = currentTime;
 
 	switch (_state) {
+	default:
+		// fallthrough intended
 	case kHidden:
 		return; // Nothing to do
 	case kShown:
diff --git a/backends/cloud/cloudmanager.cpp b/backends/cloud/cloudmanager.cpp
index 38089db..5d805b2 100644
--- a/backends/cloud/cloudmanager.cpp
+++ b/backends/cloud/cloudmanager.cpp
@@ -58,6 +58,8 @@ Common::String CloudManager::getStorageConfigName(uint32 index) const {
 	case kStorageOneDriveId: return "OneDrive";
 	case kStorageGoogleDriveId: return "GoogleDrive";
 	case kStorageBoxId: return "Box";
+	default:
+		break;
 	}
 	assert(false); // Unhandled StorageID value
 	return "";
@@ -79,6 +81,7 @@ void CloudManager::loadStorage() {
 		break;
 	default:
 		_activeStorage = nullptr;
+		break;
 	}
 
 	if (!_activeStorage) {
@@ -271,6 +274,8 @@ void CloudManager::connectStorage(uint32 index, Common::String code, Networking:
 	case kStorageBoxId:
 		new Box::BoxStorage(code, cb);
 		break;
+	default:
+		break;
 	}
 	// in these constructors Storages request token using the passed code
 	// when the token is received, they call replaceStorage()
@@ -296,6 +301,8 @@ void CloudManager::disconnectStorage(uint32 index) {
 	case kStorageBoxId:
 		Box::BoxStorage::removeFromConfig(kStoragePrefix + name + "_");
 		break;
+	default:
+		break;
 	}
 
 	switchStorage(kStorageNoneId);





More information about the Scummvm-git-logs mailing list