[Scummvm-git-logs] scummvm master -> 452b380976bd27874b42087b835007d880b75c08

digitall 547637+digitall at users.noreply.github.com
Sat Oct 5 01:33:54 CEST 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
452b380976 GRAPHICS: MACGUI: Fix GCC Signed vs. Unsigned Warnings


Commit: 452b380976bd27874b42087b835007d880b75c08
    https://github.com/scummvm/scummvm/commit/452b380976bd27874b42087b835007d880b75c08
Author: D G Turner (digitall at scummvm.org)
Date: 2019-10-05T00:31:11+01:00

Commit Message:
GRAPHICS: MACGUI: Fix GCC Signed vs. Unsigned Warnings

Changed paths:
    graphics/macgui/macmenu.cpp


diff --git a/graphics/macgui/macmenu.cpp b/graphics/macgui/macmenu.cpp
index d4543e3..2f95d01 100644
--- a/graphics/macgui/macmenu.cpp
+++ b/graphics/macgui/macmenu.cpp
@@ -332,11 +332,11 @@ MacMenuSubMenu *MacMenu::addSubMenu(MacMenuSubMenu *submenu, int index) {
 
 MacMenuSubMenu *MacMenu::getSubmenu(MacMenuSubMenu *submenu, int index) {
 	if (submenu == nullptr) {
-		if (index >= _items.size())
+		if (index < 0 || (uint)index >= _items.size())
 			return nullptr;
 		return _items[index]->submenu;
 	} else {
-		if (index >= submenu->items.size())
+		if (index < 0 || (uint)index >= submenu->items.size())
 			return nullptr;
 		return submenu->items[index]->submenu;
 	}





More information about the Scummvm-git-logs mailing list