[Scummvm-git-logs] scummvm master -> 506817952ce4f641ed70b113a1b17c9986d5b241

sev- sev at scummvm.org
Sat Oct 12 15:32:45 CEST 2019


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
506817952c MACOS: Fix crash in app menu creation


Commit: 506817952ce4f641ed70b113a1b17c9986d5b241
    https://github.com/scummvm/scummvm/commit/506817952ce4f641ed70b113a1b17c9986d5b241
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2019-10-12T15:32:18+02:00

Commit Message:
MACOS: Fix crash in app menu creation

Changed paths:
    backends/updates/macosx/macosx-updates.mm


diff --git a/backends/updates/macosx/macosx-updates.mm b/backends/updates/macosx/macosx-updates.mm
index 64dcbf6..bf524e5 100644
--- a/backends/updates/macosx/macosx-updates.mm
+++ b/backends/updates/macosx/macosx-updates.mm
@@ -83,9 +83,6 @@ MacOSXUpdateManager::MacOSXUpdateManager() {
 	// Set the target of the new menu item
 	[updateMenuItem setTarget:sparkleUpdater];
 
-	// Finally give up our references to the objects
-	[menuItem release];
-
 	if (!ConfMan.hasKey("updates_check")
 			|| ConfMan.getInt("updates_check") == Common::UpdateManager::kUpdateIntervalNotSupported) {
 		setAutomaticallyChecksForUpdates(kUpdateStateDisabled);





More information about the Scummvm-git-logs mailing list