[Scummvm-git-logs] scummvm master -> 4b1929b6dc6e4cca6d2668b219c4106a5e551f3d

sev- sev at scummvm.org
Thu Apr 2 14:11:03 UTC 2020


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
4b1929b6dc DIRECTOR: Fix warnings


Commit: 4b1929b6dc6e4cca6d2668b219c4106a5e551f3d
    https://github.com/scummvm/scummvm/commit/4b1929b6dc6e4cca6d2668b219c4106a5e551f3d
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-04-02T16:10:46+02:00

Commit Message:
DIRECTOR: Fix warnings

Changed paths:
    engines/director/lingo/lingo-code.cpp
    engines/director/lingo/lingo-events.cpp


diff --git a/engines/director/lingo/lingo-code.cpp b/engines/director/lingo/lingo-code.cpp
index aa2c407fe6..1173441816 100644
--- a/engines/director/lingo/lingo-code.cpp
+++ b/engines/director/lingo/lingo-code.cpp
@@ -789,7 +789,7 @@ void LC::c_of() {
 		}
 	}
 
-	if (first_item.u.i > 0) {
+	if (first_item.u.i > 0 || last_item.u.i > 0) {
 		warning("STUB: c_of item indexing");
 	}
 
diff --git a/engines/director/lingo/lingo-events.cpp b/engines/director/lingo/lingo-events.cpp
index b9aae882a0..fd9716b2b7 100644
--- a/engines/director/lingo/lingo-events.cpp
+++ b/engines/director/lingo/lingo-events.cpp
@@ -243,10 +243,9 @@ void Lingo::processFrameEvent(LEvent event) {
 
 void Lingo::processGenericEvent(LEvent event) {
 	// Movie Script
-	int id = -1;
 	if (event == kEventStart || event == kEventPrepareMovie ||
-		event == kEventStartMovie || event == kEventStopMovie)
-		id = 0;
+			event == kEventStartMovie || event == kEventStopMovie)
+		; // we're OK
 	else
 		warning("STUB: processGenericEvent called for unprocessed event, additional logic probably needed");
 




More information about the Scummvm-git-logs mailing list