[Scummvm-git-logs] scummvm master -> 786af20bc7f338eacd45df3d80149e802c4a427e
sev-
sev at scummvm.org
Thu Apr 23 23:42:06 UTC 2020
This automated email contains information about 7 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
915d4615ba GRAPHICS: Added mask-driven transparency blitting to ManagedSurface
128de34ba0 DIRECTOR: Use mask-based blitting.
982e931c82 TUCKER: Add override keywords
ec72b0d980 TITANIC: Added override keywords
2ba6d5151f LASTEXPRESS: Added override keywords
2a5f16faac QUEEN: Added override keyword
786af20bc7 WINTERMUTE: Added override keyword
Commit: 915d4615ba2ee8839d6de5aa37755e6b586d6796
https://github.com/scummvm/scummvm/commit/915d4615ba2ee8839d6de5aa37755e6b586d6796
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-04-24T00:51:24+02:00
Commit Message:
GRAPHICS: Added mask-driven transparency blitting to ManagedSurface
Changed paths:
graphics/managed_surface.cpp
graphics/managed_surface.h
diff --git a/graphics/managed_surface.cpp b/graphics/managed_surface.cpp
index 9bcbf6e855..2075632145 100644
--- a/graphics/managed_surface.cpp
+++ b/graphics/managed_surface.cpp
@@ -287,37 +287,59 @@ void ManagedSurface::blitFromInner(const Surface &src, const Common::Rect &srcRe
addDirtyRect(Common::Rect(0, 0, this->w, this->h));
}
-void ManagedSurface::transBlitFrom(const Surface &src, uint transColor, bool flipped, uint overrideColor, uint srcAlpha) {
+void ManagedSurface::transBlitFrom(const Surface &src, uint transColor, bool flipped,
+ uint overrideColor, uint srcAlpha) {
transBlitFrom(src, Common::Rect(0, 0, src.w, src.h), Common::Rect(0, 0, this->w, this->h),
- transColor, flipped, overrideColor);
+ transColor, flipped, overrideColor, srcAlpha);
}
void ManagedSurface::transBlitFrom(const Surface &src, const Common::Point &destPos,
uint transColor, bool flipped, uint overrideColor, uint srcAlpha) {
transBlitFrom(src, Common::Rect(0, 0, src.w, src.h), Common::Rect(destPos.x, destPos.y,
- destPos.x + src.w, destPos.y + src.h), transColor, flipped, overrideColor);
+ destPos.x + src.w, destPos.y + src.h), transColor, flipped, overrideColor, srcAlpha);
+}
+
+void ManagedSurface::transBlitFrom(const Surface &src, const Common::Point &destPos,
+ const ManagedSurface &mask) {
+ transBlitFrom(src, Common::Rect(0, 0, src.w, src.h), Common::Rect(destPos.x, destPos.y,
+ destPos.x + src.w, destPos.y + src.h), 0, false, 0, 0xff, &mask._innerSurface, true);
+}
+
+void ManagedSurface::transBlitFrom(const Surface &src, const Common::Point &destPos,
+ const Surface &mask) {
+ transBlitFrom(src, Common::Rect(0, 0, src.w, src.h), Common::Rect(destPos.x, destPos.y,
+ destPos.x + src.w, destPos.y + src.h), 0, false, 0, 0xff, &mask, true);
}
void ManagedSurface::transBlitFrom(const Surface &src, const Common::Rect &srcRect,
const Common::Point &destPos, uint transColor, bool flipped, uint overrideColor, uint srcAlpha) {
transBlitFrom(src, srcRect, Common::Rect(destPos.x, destPos.y,
- destPos.x + srcRect.width(), destPos.y + srcRect.height()), transColor, flipped, overrideColor);
+ destPos.x + srcRect.width(), destPos.y + srcRect.height()), transColor, flipped, overrideColor, srcAlpha);
}
void ManagedSurface::transBlitFrom(const Surface &src, const Common::Rect &srcRect,
- const Common::Rect &destRect, uint transColor, bool flipped, uint overrideColor, uint srcAlpha) {
- transBlitFromInner(src, srcRect, destRect, transColor, flipped, overrideColor, srcAlpha, nullptr);
+ const Common::Rect &destRect, uint transColor, bool flipped, uint overrideColor, uint srcAlpha,
+ const Surface *mask, bool maskOnly) {
+ transBlitFromInner(src, srcRect, destRect, transColor, flipped, overrideColor, srcAlpha,
+ nullptr, mask, maskOnly);
}
-void ManagedSurface::transBlitFrom(const ManagedSurface &src, uint transColor, bool flipped, uint overrideColor, uint srcAlpha) {
+void ManagedSurface::transBlitFrom(const ManagedSurface &src, uint transColor, bool flipped,
+ uint overrideColor, uint srcAlpha) {
transBlitFrom(src, Common::Rect(0, 0, src.w, src.h), Common::Rect(0, 0, this->w, this->h),
- transColor, flipped, overrideColor);
+ transColor, flipped, overrideColor, srcAlpha);
}
void ManagedSurface::transBlitFrom(const ManagedSurface &src, const Common::Point &destPos,
- uint transColor, bool flipped, uint overrideColor, uint srcAlpha) {
+ uint transColor, bool flipped, uint overrideColor, uint srcAlpha) {
transBlitFrom(src, Common::Rect(0, 0, src.w, src.h), Common::Rect(destPos.x, destPos.y,
- destPos.x + src.w, destPos.y + src.h), transColor, flipped, overrideColor);
+ destPos.x + src.w, destPos.y + src.h), transColor, flipped, overrideColor, srcAlpha);
+}
+
+void ManagedSurface::transBlitFrom(const ManagedSurface &src, const Common::Point &destPos,
+ const ManagedSurface &mask) {
+ transBlitFrom(src, Common::Rect(0, 0, src.w, src.h), Common::Rect(destPos.x, destPos.y,
+ destPos.x + src.w, destPos.y + src.h), 0, false, 0, 0xff, &mask._innerSurface, true);
}
void ManagedSurface::transBlitFrom(const ManagedSurface &src, const Common::Rect &srcRect,
@@ -325,22 +347,24 @@ void ManagedSurface::transBlitFrom(const ManagedSurface &src, const Common::Rect
uint tColor = !transColor && src._transparentColorSet ? src._transparentColor : transColor;
transBlitFrom(src, srcRect, Common::Rect(destPos.x, destPos.y, destPos.x + srcRect.width(),
- destPos.y + srcRect.height()), tColor, flipped, overrideColor);
+ destPos.y + srcRect.height()), tColor, flipped, overrideColor, srcAlpha);
}
void ManagedSurface::transBlitFrom(const ManagedSurface &src, const Common::Rect &srcRect,
- const Common::Rect &destRect, uint transColor, bool flipped, uint overrideColor, uint srcAlpha) {
+ const Common::Rect &destRect, uint transColor, bool flipped, uint overrideColor, uint srcAlpha,
+ const Surface *mask, bool maskOnly) {
if (transColor == (uint)-1 && src._transparentColorSet)
transColor = src._transparentColor;
const uint32 *palette = src._paletteSet ? src._palette : nullptr;
transBlitFromInner(src._innerSurface, srcRect, destRect, transColor, flipped, overrideColor,
- srcAlpha, palette);
+ srcAlpha, palette, mask, maskOnly);
}
template<typename TSRC, typename TDEST>
void transBlit(const Surface &src, const Common::Rect &srcRect, Surface &dest, const Common::Rect &destRect,
- TSRC transColor, bool flipped, uint overrideColor, uint srcAlpha, const uint32 *palette) {
+ TSRC transColor, bool flipped, uint overrideColor, uint srcAlpha, const uint32 *palette,
+ const Surface *mask, bool maskOnly) {
int scaleX = SCALE_THRESHOLD * srcRect.width() / destRect.width();
int scaleY = SCALE_THRESHOLD * srcRect.height() / destRect.height();
const Graphics::PixelFormat &srcFormat = src.format;
@@ -354,6 +378,11 @@ void transBlit(const Surface &src, const Common::Rect &srcRect, Surface &dest, c
if (destY < 0 || destY >= dest.h)
continue;
const TSRC *srcLine = (const TSRC *)src.getBasePtr(srcRect.left, scaleYCtr / SCALE_THRESHOLD + srcRect.top);
+ const TSRC *mskLine = nullptr;
+
+ if (mask)
+ mskLine = (const TSRC *)mask->getBasePtr(srcRect.left, scaleYCtr / SCALE_THRESHOLD + srcRect.top);
+
TDEST *destLine = (TDEST *)dest.getBasePtr(destRect.left, destY);
// Loop through drawing the pixels of the row
@@ -362,9 +391,15 @@ void transBlit(const Surface &src, const Common::Rect &srcRect, Surface &dest, c
continue;
TSRC srcVal = srcLine[flipped ? src.w - scaleXCtr / SCALE_THRESHOLD - 1 : scaleXCtr / SCALE_THRESHOLD];
- if (srcVal == transColor)
+ if (srcVal == transColor && !maskOnly)
continue;
+ if (mask) {
+ TSRC mskVal = mskLine[flipped ? src.w - scaleXCtr / SCALE_THRESHOLD - 1 : scaleXCtr / SCALE_THRESHOLD];
+ if (!mskVal)
+ continue;
+ }
+
if (srcFormat == destFormat && srcAlpha == 0xff) {
// Matching formats, so we can do a straight copy
destLine[xCtr] = overrideColor ? overrideColor : srcVal;
@@ -412,15 +447,20 @@ void transBlit(const Surface &src, const Common::Rect &srcRect, Surface &dest, c
#define HANDLE_BLIT(SRC_BYTES, DEST_BYTES, SRC_TYPE, DEST_TYPE) \
if (src.format.bytesPerPixel == SRC_BYTES && format.bytesPerPixel == DEST_BYTES) \
- transBlit<SRC_TYPE, DEST_TYPE>(src, srcRect, _innerSurface, destRect, transColor, flipped, overrideColor, srcAlpha, palette); \
+ transBlit<SRC_TYPE, DEST_TYPE>(src, srcRect, _innerSurface, destRect, transColor, flipped, overrideColor, srcAlpha, palette, mask, maskOnly); \
else
void ManagedSurface::transBlitFromInner(const Surface &src, const Common::Rect &srcRect,
const Common::Rect &destRect, uint transColor, bool flipped, uint overrideColor,
- uint srcAlpha, const uint32 *palette) {
+ uint srcAlpha, const uint32 *palette, const Surface *mask, bool maskOnly) {
if (src.w == 0 || src.h == 0 || destRect.width() == 0 || destRect.height() == 0)
return;
+ if (mask) {
+ if (mask->w != src.w || mask->h != src.h)
+ error("Surface::transBlitFrom: mask dimensions do not match src");
+ }
+
HANDLE_BLIT(1, 1, byte, byte)
HANDLE_BLIT(1, 2, byte, uint16)
HANDLE_BLIT(1, 4, byte, uint32)
@@ -457,7 +497,7 @@ void ManagedSurface::clear(uint color) {
void ManagedSurface::setPalette(const byte *colors, uint start, uint num) {
assert(start < 256 && (start + num) <= 256);
uint32 *dest = &_palette[start];
-
+
for (; num > 0; --num, colors += 3) {
*dest++ = colors[0] | (colors[1] << 8) | (colors[2] << 16) | (0xff << 24);
}
diff --git a/graphics/managed_surface.h b/graphics/managed_surface.h
index d117ff2e91..290b04aba4 100644
--- a/graphics/managed_surface.h
+++ b/graphics/managed_surface.h
@@ -92,7 +92,7 @@ protected:
*/
void transBlitFromInner(const Surface &src, const Common::Rect &srcRect,
const Common::Rect &destRect, uint transColor, bool flipped, uint overrideColor,
- uint srcAlpha, const uint32 *palette);
+ uint srcAlpha, const uint32 *palette, const Surface *mask, bool maskOnly);
public:
/**
* Clips the given source bounds so the passed destBounds will be entirely on-screen
@@ -279,7 +279,8 @@ public:
* the source surface
* @param srcAlpha Optional additional transparency applied to src
*/
- void transBlitFrom(const Surface &src, uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff);
+ void transBlitFrom(const Surface &src, uint transColor = 0, bool flipped = false,
+ uint overrideColor = 0, uint srcAlpha = 0xff);
/**
* Copies another surface into this one ignoring pixels of a designated transparent color
@@ -294,6 +295,24 @@ public:
void transBlitFrom(const Surface &src, const Common::Point &destPos,
uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff);
+ /**
+ * Copies another surface into this one ignoring pixels of a designated transparent color
+ * @param src Source surface
+ * @param destPos Destination position to draw the surface
+ * @param mask Mask definition (0-skip, other-copy)
+ */
+ void transBlitFrom(const Surface &src, const Common::Point &destPos,
+ const ManagedSurface &mask);
+
+ /**
+ * Copies another surface into this one ignoring pixels of a designated transparent color
+ * @param src Source surface
+ * @param destPos Destination position to draw the surface
+ * @param mask Mask definition (0-skip, other-copy)
+ */
+ void transBlitFrom(const Surface &src, const Common::Point &destPos,
+ const Surface &mask);
+
/**
* Copies another surface into this one ignoring pixels of a designated transparent color
* @param src Source surface
@@ -304,6 +323,8 @@ public:
* @param overrideColor Optional color to use instead of non-transparent pixels from
* the source surface
* @param srcAlpha Optional additional transparency applied to src
+ * @param mask Optional parameter with mask definition (0-skip, other-copy)
+ * @param maskOnly Optional parameter for using mask over transColor
*/
void transBlitFrom(const Surface &src, const Common::Rect &srcRect, const Common::Point &destPos,
uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff);
@@ -319,9 +340,12 @@ public:
* @param overrideColor Optional color to use instead of non-transparent pixels from
* the source surface
* @param srcAlpha Optional additional transparency applied to src
+ * @param mask Optional parameter with mask definition (0-skip, other-copy)
+ * @param maskOnly Optional parameter for using mask over transColor
*/
void transBlitFrom(const Surface &src, const Common::Rect &srcRect, const Common::Rect &destRect,
- uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff);
+ uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff,
+ const Surface *mask = nullptr, bool maskOnly = false);
/**
* Copies another surface into this one ignoring pixels of a designated transparent color
@@ -332,7 +356,8 @@ public:
* the source surface
* @param srcAlpha Optional additional transparency applied to src
*/
- void transBlitFrom(const ManagedSurface &src, uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff);
+ void transBlitFrom(const ManagedSurface &src, uint transColor = 0, bool flipped = false,
+ uint overrideColor = 0, uint srcAlpha = 0xff);
/**
* Copies another surface into this one ignoring pixels of a designated transparent color
@@ -347,6 +372,15 @@ public:
void transBlitFrom(const ManagedSurface &src, const Common::Point &destPos,
uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff);
+ /**
+ * Copies another surface into this one ignoring pixels of a designated transparent color
+ * @param src Source surface
+ * @param destPos Destination position to draw the surface
+ * @param mask Mask definition (0-skip, other-copy)
+ */
+ void transBlitFrom(const ManagedSurface &src, const Common::Point &destPos,
+ const ManagedSurface &mask);
+
/**
* Copies another surface into this one ignoring pixels of a designated transparent color
* @param src Source surface
@@ -374,7 +408,8 @@ public:
* @param srcAlpha Optional additional transparency applied to src
*/
void transBlitFrom(const ManagedSurface &src, const Common::Rect &srcRect, const Common::Rect &destRect,
- uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff);
+ uint transColor = 0, bool flipped = false, uint overrideColor = 0, uint srcAlpha = 0xff,
+ const Surface *mask = nullptr, bool maskOnly = false);
/**
* Clear the entire surface
Commit: 128de34ba08816cdaaefa024e9d1002afb6bf742
https://github.com/scummvm/scummvm/commit/128de34ba08816cdaaefa024e9d1002afb6bf742
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-04-24T00:57:05+02:00
Commit Message:
DIRECTOR: Use mask-based blitting.
Only Copy ink is implemented so far
Changed paths:
engines/director/frame.cpp
engines/director/frame.h
diff --git a/engines/director/frame.cpp b/engines/director/frame.cpp
index 94cd894673..6b14ea94b4 100644
--- a/engines/director/frame.cpp
+++ b/engines/director/frame.cpp
@@ -717,7 +717,7 @@ void Frame::renderShape(Graphics::ManagedSurface &surface, uint16 spriteId) {
// Draw fill
Common::Rect fillRect((int)shapeRect.width(), (int)shapeRect.height());
- Graphics::MacPlotData plotFill(&tmpSurface, nullptr, &_vm->getPatterns(), sp->getPattern(), -shapeRect.left, -shapeRect.top, 1, backColor);
+ Graphics::MacPlotData plotFill(&tmpSurface, &maskSurface, &_vm->getPatterns(), sp->getPattern(), -shapeRect.left, -shapeRect.top, 1, backColor);
switch (spriteType) {
case kRectangleSprite:
Graphics::drawFilledRect(fillRect, foreColor, Graphics::macDrawPixel, &plotFill);
@@ -737,7 +737,7 @@ void Frame::renderShape(Graphics::ManagedSurface &surface, uint16 spriteId) {
// Draw stroke
Common::Rect strokeRect(MAX((int)shapeRect.width() - lineSize, 0), MAX((int)shapeRect.height() - lineSize, 0));
- Graphics::MacPlotData plotStroke(&tmpSurface, nullptr, &_vm->getPatterns(), 1, -shapeRect.left, -shapeRect.top, lineSize, backColor);
+ Graphics::MacPlotData plotStroke(&tmpSurface, &maskSurface, &_vm->getPatterns(), 1, -shapeRect.left, -shapeRect.top, lineSize, backColor);
switch (spriteType) {
case kLineTopBottomSprite:
Graphics::drawLine(strokeRect.left, strokeRect.top, strokeRect.right, strokeRect.bottom, foreColor, Graphics::macDrawPixel, &plotStroke);
@@ -766,7 +766,7 @@ void Frame::renderShape(Graphics::ManagedSurface &surface, uint16 spriteId) {
}
addDrawRect(spriteId, shapeRect);
- inkBasedBlit(surface, tmpSurface, ink, shapeRect, spriteId);
+ inkBasedBlit(surface, &maskSurface, tmpSurface, ink, shapeRect, spriteId);
}
void Frame::renderButton(Graphics::ManagedSurface &surface, uint16 spriteId) {
@@ -899,7 +899,7 @@ void Frame::renderText(Graphics::ManagedSurface &surface, uint16 spriteId, Commo
if (spriteId == score->_currentMouseDownSpriteId)
ink = kInkTypeReverse;
- inkBasedBlit(surface, textCast->_widget->getSurface()->rawSurface(), ink, Common::Rect(x, y, x + width, y + height), spriteId);
+ inkBasedBlit(surface, nullptr, textCast->_widget->getSurface()->rawSurface(), ink, Common::Rect(x, y, x + width, y + height), spriteId);
return;
}
@@ -1032,7 +1032,7 @@ void Frame::renderText(Graphics::ManagedSurface &surface, uint16 spriteId, Commo
if (spriteId == score->_currentMouseDownSpriteId)
ink = kInkTypeReverse;
- inkBasedBlit(surface, textWithFeatures, ink, Common::Rect(x, y, x + width, y + height), spriteId);
+ inkBasedBlit(surface, nullptr, textWithFeatures, ink, Common::Rect(x, y, x + width, y + height), spriteId);
}
void Frame::renderBitmap(Graphics::ManagedSurface &surface, uint16 spriteId) {
@@ -1057,10 +1057,10 @@ void Frame::renderBitmap(Graphics::ManagedSurface &surface, uint16 spriteId) {
int width = _vm->getVersion() > 4 ? bc->_initialRect.width() : sprite->_width;
Common::Rect drawRect(x, y, x + width, y + height);
addDrawRect(spriteId, drawRect);
- inkBasedBlit(surface, *(bc->_surface), ink, drawRect, spriteId);
+ inkBasedBlit(surface, nullptr, *(bc->_surface), ink, drawRect, spriteId);
}
-void Frame::inkBasedBlit(Graphics::ManagedSurface &targetSurface, const Graphics::Surface &spriteSurface, InkType ink, Common::Rect drawRect, uint spriteId) {
+void Frame::inkBasedBlit(Graphics::ManagedSurface &targetSurface, const Graphics::ManagedSurface *maskSurface, const Graphics::Surface &spriteSurface, InkType ink, Common::Rect drawRect, uint spriteId) {
// drawRect could be bigger than the spriteSurface. Clip it
Common::Rect t(spriteSurface.w, spriteSurface.h);
t.moveTo(drawRect.left, drawRect.top);
@@ -1068,7 +1068,10 @@ void Frame::inkBasedBlit(Graphics::ManagedSurface &targetSurface, const Graphics
switch (ink) {
case kInkTypeCopy:
- targetSurface.blitFrom(spriteSurface, Common::Point(drawRect.left, drawRect.top));
+ if (maskSurface)
+ targetSurface.transBlitFrom(spriteSurface, Common::Point(drawRect.left, drawRect.top), *maskSurface);
+ else
+ targetSurface.blitFrom(spriteSurface, Common::Point(drawRect.left, drawRect.top));
break;
case kInkTypeTransparent:
// FIXME: is it always white (last entry in pallette)?
diff --git a/engines/director/frame.h b/engines/director/frame.h
index 7d773bd8ac..cd1f2c636e 100644
--- a/engines/director/frame.h
+++ b/engines/director/frame.h
@@ -96,7 +96,7 @@ private:
void drawMatteSprite(Graphics::ManagedSurface &target, const Graphics::Surface &sprite, Common::Rect &drawRect);
void drawGhostSprite(Graphics::ManagedSurface &target, const Graphics::Surface &sprite, Common::Rect &drawRect);
void drawReverseSprite(Graphics::ManagedSurface &target, const Graphics::Surface &sprite, Common::Rect &drawRect, uint16 spriteId);
- void inkBasedBlit(Graphics::ManagedSurface &targetSurface, const Graphics::Surface &spriteSurface, InkType ink, Common::Rect drawRect, uint spriteId);
+ void inkBasedBlit(Graphics::ManagedSurface &targetSurface, const Graphics::ManagedSurface *maskSurface, const Graphics::Surface &spriteSurface, InkType ink, Common::Rect drawRect, uint spriteId);
void addDrawRect(uint16 entityId, Common::Rect &rect);
public:
Commit: 982e931c829ea98f1416b48b97c3bae866f4b050
https://github.com/scummvm/scummvm/commit/982e931c829ea98f1416b48b97c3bae866f4b050
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-04-24T01:03:56+02:00
Commit Message:
TUCKER: Add override keywords
Changed paths:
engines/tucker/tucker.h
diff --git a/engines/tucker/tucker.h b/engines/tucker/tucker.h
index 20f02ffd70..cee52f7804 100644
--- a/engines/tucker/tucker.h
+++ b/engines/tucker/tucker.h
@@ -747,7 +747,7 @@ protected:
Common::Error saveGameState(int slot, const Common::String &desc, bool isAutosave = false) override;
SavegameError writeSavegameHeader(Common::OutSaveFile *file, SavegameHeader &header);
virtual int getAutosaveSlot() const override { return kAutoSaveSlot; }
- virtual Common::String getSaveStateName(int slot) const {
+ virtual Common::String getSaveStateName(int slot) const override {
return Common::String::format("%s.%d", _targetName.c_str(), slot);
}
Commit: ec72b0d98043456adb791a91a7f533463432bdab
https://github.com/scummvm/scummvm/commit/ec72b0d98043456adb791a91a7f533463432bdab
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-04-24T01:08:10+02:00
Commit Message:
TITANIC: Added override keywords
Changed paths:
engines/titanic/core/message_target.h
engines/titanic/core/saveable_object.h
diff --git a/engines/titanic/core/message_target.h b/engines/titanic/core/message_target.h
index e5bdc1438c..8048c51eba 100644
--- a/engines/titanic/core/message_target.h
+++ b/engines/titanic/core/message_target.h
@@ -45,7 +45,7 @@ struct MSGMAP {
#define DECLARE_MESSAGE_MAP \
protected: \
static const MSGMAP *getThisMessageMap(); \
- virtual const MSGMAP *getMessageMap() const
+ virtual const MSGMAP *getMessageMap() const override
#define BEGIN_MESSAGE_MAP(theClass, baseClass) \
const MSGMAP *theClass::getMessageMap() const \
@@ -84,7 +84,10 @@ protected: \
enum { DUMMY }
class CMessageTarget: public CSaveableObject {
- DECLARE_MESSAGE_MAP;
+protected:
+ static const MSGMAP *getThisMessageMap();
+ virtual const MSGMAP *getMessageMap() const;
+
public:
CLASSDEF;
diff --git a/engines/titanic/core/saveable_object.h b/engines/titanic/core/saveable_object.h
index 1fa09ac8fc..65b2ddebb2 100644
--- a/engines/titanic/core/saveable_object.h
+++ b/engines/titanic/core/saveable_object.h
@@ -54,7 +54,7 @@ public:
#define CLASSDEF \
static ClassDef *_type; \
- virtual ClassDef *getType() const { return _type; }
+ virtual ClassDef *getType() const override { return _type; }
class CSaveableObject {
typedef CSaveableObject *(*CreateFunction)();
@@ -79,7 +79,9 @@ public:
*/
static CSaveableObject *createInstance(const Common::String &name);
public:
- CLASSDEF
+ static ClassDef *_type; \
+ virtual ClassDef *getType() const { return _type; }
+
virtual ~CSaveableObject() {}
bool isInstanceOf(const ClassDef *classDef) const;
Commit: 2ba6d5151f829f614402e73bb35ebd3c3943351d
https://github.com/scummvm/scummvm/commit/2ba6d5151f829f614402e73bb35ebd3c3943351d
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-04-24T01:33:38+02:00
Commit Message:
LASTEXPRESS: Added override keywords
Changed paths:
engines/lastexpress/entities/abbot.h
engines/lastexpress/entities/alexei.h
engines/lastexpress/entities/alouan.h
engines/lastexpress/entities/anna.h
engines/lastexpress/entities/august.h
engines/lastexpress/entities/boutarel.h
engines/lastexpress/entities/chapters.h
engines/lastexpress/entities/cooks.h
engines/lastexpress/entities/coudert.h
engines/lastexpress/entities/entity.h
engines/lastexpress/entities/entity39.h
engines/lastexpress/entities/francois.h
engines/lastexpress/entities/gendarmes.h
engines/lastexpress/entities/hadija.h
engines/lastexpress/entities/ivo.h
engines/lastexpress/entities/kahina.h
engines/lastexpress/entities/kronos.h
engines/lastexpress/entities/mahmud.h
engines/lastexpress/entities/max.h
engines/lastexpress/entities/mertens.h
engines/lastexpress/entities/milos.h
engines/lastexpress/entities/mmeboutarel.h
engines/lastexpress/entities/pascale.h
engines/lastexpress/entities/rebecca.h
engines/lastexpress/entities/salko.h
engines/lastexpress/entities/sophie.h
engines/lastexpress/entities/tables.h
engines/lastexpress/entities/tatiana.h
engines/lastexpress/entities/train.h
engines/lastexpress/entities/vassili.h
engines/lastexpress/entities/verges.h
engines/lastexpress/entities/vesna.h
engines/lastexpress/entities/waiter1.h
engines/lastexpress/entities/waiter2.h
engines/lastexpress/entities/yasmin.h
diff --git a/engines/lastexpress/entities/abbot.h b/engines/lastexpress/entities/abbot.h
index ed8799231a..b68d3f08f4 100644
--- a/engines/lastexpress/entities/abbot.h
+++ b/engines/lastexpress/entities/abbot.h
@@ -52,7 +52,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -95,7 +95,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Saves the game
@@ -103,7 +103,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -111,7 +111,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Call a savepoint (or draw sequence in default case)
@@ -140,17 +140,17 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -180,7 +180,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Search Cath by walking around
@@ -206,7 +206,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/alexei.h b/engines/lastexpress/entities/alexei.h
index 536b43668d..4a0aa96914 100644
--- a/engines/lastexpress/entities/alexei.h
+++ b/engines/lastexpress/entities/alexei.h
@@ -44,7 +44,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Updates parameter 2 using time value
@@ -75,7 +75,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Process callback action when the entity direction is not kDirectionRight
@@ -98,7 +98,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -106,7 +106,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Draws the entity along with another one
@@ -138,7 +138,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -157,7 +157,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -169,7 +169,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -182,7 +182,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -201,7 +201,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
};
} // End of namespace LastExpress
diff --git a/engines/lastexpress/entities/alouan.h b/engines/lastexpress/entities/alouan.h
index 19b09712bd..41850dcc3b 100644
--- a/engines/lastexpress/entities/alouan.h
+++ b/engines/lastexpress/entities/alouan.h
@@ -45,14 +45,14 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Plays sound
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Updates parameter 2 using time value
@@ -67,7 +67,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION(peekF)
DECLARE_FUNCTION(peekH)
@@ -77,7 +77,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -88,7 +88,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -98,7 +98,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -108,7 +108,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -119,7 +119,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/anna.h b/engines/lastexpress/entities/anna.h
index 9dfef5f7e3..d5bef23aee 100644
--- a/engines/lastexpress/entities/anna.h
+++ b/engines/lastexpress/entities/anna.h
@@ -61,7 +61,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Process callback action when the entity direction is not kDirectionRight
@@ -83,7 +83,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Process callback action when somebody is standing in the restaurant or salon.
@@ -96,7 +96,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -104,7 +104,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Updates parameter 2 using time value
@@ -136,7 +136,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION_2(doWalkP1, uint32, uint32)
@@ -172,7 +172,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -182,7 +182,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -212,7 +212,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -228,7 +228,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/august.h b/engines/lastexpress/entities/august.h
index 2d923155f2..b1d9e7e8e9 100644
--- a/engines/lastexpress/entities/august.h
+++ b/engines/lastexpress/entities/august.h
@@ -68,7 +68,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -124,7 +124,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Plays sound
@@ -144,7 +144,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -152,7 +152,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION_1(function17, TimeValue timeValue)
@@ -172,7 +172,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION_1(function23, TimeValue timeValue)
DECLARE_FUNCTION(dinner)
@@ -195,7 +195,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -209,7 +209,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION_2(function41, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION_3(function42, CarIndex car, EntityPosition entityPosition, bool)
@@ -236,7 +236,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
*/
@@ -253,7 +253,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/boutarel.h b/engines/lastexpress/entities/boutarel.h
index ca425e4bd8..ab9255471f 100644
--- a/engines/lastexpress/entities/boutarel.h
+++ b/engines/lastexpress/entities/boutarel.h
@@ -44,7 +44,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Draws the entity
@@ -75,7 +75,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -101,7 +101,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION_1(function11, bool)
DECLARE_FUNCTION(enterTableWithMmeBoutarel)
@@ -115,7 +115,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(function20)
/**
@@ -128,7 +128,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -140,7 +140,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -154,7 +154,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -168,7 +168,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/chapters.h b/engines/lastexpress/entities/chapters.h
index 435d7f0a3e..00bdcf1bbe 100644
--- a/engines/lastexpress/entities/chapters.h
+++ b/engines/lastexpress/entities/chapters.h
@@ -40,7 +40,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Exit a train station
@@ -60,7 +60,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Reset main entities
@@ -90,7 +90,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Init Chapter 2 data
@@ -105,7 +105,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Init Chapter 3 data
@@ -125,7 +125,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Init Chapter 4 data
@@ -140,7 +140,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Init Chapter 5 data
diff --git a/engines/lastexpress/entities/cooks.h b/engines/lastexpress/entities/cooks.h
index c222ebe209..1c5837b083 100644
--- a/engines/lastexpress/entities/cooks.h
+++ b/engines/lastexpress/entities/cooks.h
@@ -46,7 +46,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
DECLARE_FUNCTION(uptrainVersion)
@@ -55,7 +55,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Chapter 1: Prepare dinner in kitchen
@@ -67,7 +67,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/*
* Chapter 2: Prepare breakfast in kitchen
@@ -77,7 +77,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Chapter 3: Prepare lunch in kitchen
@@ -87,7 +87,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Chapter 4: Prepare second dinner in kitchen
@@ -97,7 +97,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
};
} // End of namespace LastExpress
diff --git a/engines/lastexpress/entities/coudert.h b/engines/lastexpress/entities/coudert.h
index e985c62756..4e96a7c956 100644
--- a/engines/lastexpress/entities/coudert.h
+++ b/engines/lastexpress/entities/coudert.h
@@ -51,7 +51,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Process callback action when the entity direction is not kDirectionRight
@@ -73,7 +73,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Plays sound
@@ -89,7 +89,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -97,7 +97,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Updates parameter 2 using time value
@@ -156,7 +156,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(function37)
DECLARE_FUNCTION(function38)
DECLARE_FUNCTION(function39)
@@ -171,14 +171,14 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
DECLARE_FUNCTION(function43)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION(function45)
DECLARE_FUNCTION(function46)
@@ -191,7 +191,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
DECLARE_FUNCTION(function53)
DECLARE_FUNCTION(function54)
@@ -201,7 +201,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/entity.h b/engines/lastexpress/entities/entity.h
index 55bf9de8b9..431d6cec14 100644
--- a/engines/lastexpress/entities/entity.h
+++ b/engines/lastexpress/entities/entity.h
@@ -48,14 +48,26 @@ struct SavePoint;
void setup_##name(); \
void name(const SavePoint &savepoint);
+#define DECLARE_VFUNCTION(name) \
+ virtual void setup_##name() override; \
+ void name(const SavePoint &savepoint);
+
#define DECLARE_FUNCTION_1(name, param1) \
void setup_##name(param1); \
void name(const SavePoint &savepoint);
+#define DECLARE_VFUNCTION_1(name, param1) \
+ virtual void setup_##name(param1) override; \
+ void name(const SavePoint &savepoint);
+
#define DECLARE_FUNCTION_2(name, param1, param2) \
void setup_##name(param1, param2); \
void name(const SavePoint &savepoint);
+#define DECLARE_VFUNCTION_2(name, param1, param2) \
+ virtual void setup_##name(param1, param2) override; \
+ void name(const SavePoint &savepoint);
+
#define DECLARE_FUNCTION_3(name, param1, param2, param3) \
void setup_##name(param1, param2, param3); \
void name(const SavePoint &savepoint);
diff --git a/engines/lastexpress/entities/entity39.h b/engines/lastexpress/entities/entity39.h
index 0d2d201678..d9204a3197 100644
--- a/engines/lastexpress/entities/entity39.h
+++ b/engines/lastexpress/entities/entity39.h
@@ -37,27 +37,27 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Process function
diff --git a/engines/lastexpress/entities/francois.h b/engines/lastexpress/entities/francois.h
index 287013be8d..282d6fa748 100644
--- a/engines/lastexpress/entities/francois.h
+++ b/engines/lastexpress/entities/francois.h
@@ -59,7 +59,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -74,7 +74,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Saves the game
@@ -82,7 +82,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Walk
@@ -104,7 +104,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -116,7 +116,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -127,7 +127,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -137,7 +137,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -147,7 +147,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/gendarmes.h b/engines/lastexpress/entities/gendarmes.h
index f822a32d31..b461ad4060 100644
--- a/engines/lastexpress/entities/gendarmes.h
+++ b/engines/lastexpress/entities/gendarmes.h
@@ -44,7 +44,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION_1(doDraw, const char *sequence)
DECLARE_FUNCTION_1(doDialog, const char *soundName)
@@ -57,7 +57,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
DECLARE_FUNCTION_2(doWalk, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION_4(doCompartment, CarIndex car, EntityPosition entityPosition, const char *sequence1, const char *sequence2)
@@ -69,22 +69,22 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
private:
void handleAction(const SavePoint &savepoint, bool playSound = false, SoundFlag flag = kSoundVolumeEntityDefault, bool checkCallback = false, bool shouldUpdateEntity = false);
diff --git a/engines/lastexpress/entities/hadija.h b/engines/lastexpress/entities/hadija.h
index bfa6e27c20..652404ffc5 100644
--- a/engines/lastexpress/entities/hadija.h
+++ b/engines/lastexpress/entities/hadija.h
@@ -45,14 +45,14 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Plays sound
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Updates parameter 2 using time value
@@ -68,7 +68,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION(peekF)
DECLARE_FUNCTION(peekH)
@@ -78,7 +78,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -90,7 +90,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -100,7 +100,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -110,7 +110,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -122,7 +122,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/ivo.h b/engines/lastexpress/entities/ivo.h
index 4655934df5..18ba21b4c4 100644
--- a/engines/lastexpress/entities/ivo.h
+++ b/engines/lastexpress/entities/ivo.h
@@ -52,7 +52,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Updates parameter 2 using time value
@@ -74,7 +74,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Process callback action when the entity direction is not kDirectionRight
@@ -100,7 +100,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
DECLARE_FUNCTION(goCompartment)
DECLARE_FUNCTION(sitAtTableWithSalko)
@@ -109,7 +109,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -122,7 +122,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
DECLARE_FUNCTION(goBreakfast)
DECLARE_FUNCTION(atBreakfast)
@@ -131,7 +131,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -141,7 +141,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -156,7 +156,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/kahina.h b/engines/lastexpress/entities/kahina.h
index 8d4af7ef63..0e1844d45f 100644
--- a/engines/lastexpress/entities/kahina.h
+++ b/engines/lastexpress/entities/kahina.h
@@ -44,7 +44,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Saves the game
@@ -52,7 +52,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates parameter 2 using time value
@@ -85,7 +85,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Handles entering/exiting a compartment.
@@ -93,12 +93,12 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -113,13 +113,13 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
DECLARE_FUNCTION(inSeclusionPart2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Update the entity, handling excuse me events and resetting the entity state after the argument with Anna in the baggage car
@@ -141,12 +141,12 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
};
} // End of namespace LastExpress
diff --git a/engines/lastexpress/entities/kronos.h b/engines/lastexpress/entities/kronos.h
index 4860920328..6db4b30e73 100644
--- a/engines/lastexpress/entities/kronos.h
+++ b/engines/lastexpress/entities/kronos.h
@@ -45,7 +45,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -53,7 +53,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Plays sound
@@ -82,7 +82,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -96,12 +96,12 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -121,12 +121,12 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
};
} // End of namespace LastExpress
diff --git a/engines/lastexpress/entities/mahmud.h b/engines/lastexpress/entities/mahmud.h
index ba067c7ab4..429e3f9da0 100644
--- a/engines/lastexpress/entities/mahmud.h
+++ b/engines/lastexpress/entities/mahmud.h
@@ -53,7 +53,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment.
@@ -70,7 +70,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Plays sound
@@ -93,7 +93,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -101,7 +101,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION_2(function10, ObjectIndex, bool)
DECLARE_FUNCTION(function11)
@@ -116,7 +116,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Reset chapter data
@@ -126,22 +126,22 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
};
} // End of namespace LastExpress
diff --git a/engines/lastexpress/entities/max.h b/engines/lastexpress/entities/max.h
index a0b0778122..c4f1f00286 100644
--- a/engines/lastexpress/entities/max.h
+++ b/engines/lastexpress/entities/max.h
@@ -44,7 +44,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Draws the entity
@@ -60,7 +60,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Saves the game
@@ -68,7 +68,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
DECLARE_FUNCTION(withAnna)
DECLARE_FUNCTION(guardingCompartment)
@@ -78,17 +78,17 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -101,14 +101,14 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
DECLARE_FUNCTION(function17)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
};
} // End of namespace LastExpress
diff --git a/engines/lastexpress/entities/mertens.h b/engines/lastexpress/entities/mertens.h
index aff693b449..689443dde1 100644
--- a/engines/lastexpress/entities/mertens.h
+++ b/engines/lastexpress/entities/mertens.h
@@ -61,7 +61,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -93,7 +93,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Plays sound
@@ -108,7 +108,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -116,7 +116,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION_1(function11, uint32 time)
@@ -158,7 +158,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(function35)
DECLARE_FUNCTION(function36)
DECLARE_FUNCTION(function37)
@@ -176,21 +176,21 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
DECLARE_FUNCTION(function44)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION(function46)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
DECLARE_FUNCTION(function48)
DECLARE_FUNCTION(function49)
@@ -198,7 +198,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/milos.h b/engines/lastexpress/entities/milos.h
index 8100cf882b..61f49e0efd 100644
--- a/engines/lastexpress/entities/milos.h
+++ b/engines/lastexpress/entities/milos.h
@@ -52,7 +52,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -72,7 +72,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Plays sound
@@ -87,7 +87,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates parameter 2 using time value
@@ -102,7 +102,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(function13)
DECLARE_FUNCTION(function14)
@@ -119,7 +119,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -131,7 +131,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION(function23)
DECLARE_FUNCTION(function24)
@@ -142,7 +142,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -156,7 +156,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/mmeboutarel.h b/engines/lastexpress/entities/mmeboutarel.h
index 780a407a3e..fef62bec91 100644
--- a/engines/lastexpress/entities/mmeboutarel.h
+++ b/engines/lastexpress/entities/mmeboutarel.h
@@ -44,7 +44,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Draws the entity
@@ -66,7 +66,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -82,7 +82,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION_1(function8, const char *soundName)
@@ -91,7 +91,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(function11)
@@ -108,7 +108,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -120,7 +120,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -130,7 +130,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -143,7 +143,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/pascale.h b/engines/lastexpress/entities/pascale.h
index 2c92c576cb..16c0f7cbe0 100644
--- a/engines/lastexpress/entities/pascale.h
+++ b/engines/lastexpress/entities/pascale.h
@@ -73,7 +73,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Draws the entity along with another one
@@ -93,7 +93,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(greetAugust)
DECLARE_FUNCTION(seatAnna)
@@ -111,12 +111,12 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -129,7 +129,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -144,7 +144,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/rebecca.h b/engines/lastexpress/entities/rebecca.h
index 81008f1ec5..3e861c8c6c 100644
--- a/engines/lastexpress/entities/rebecca.h
+++ b/engines/lastexpress/entities/rebecca.h
@@ -51,7 +51,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Plays sound
@@ -83,7 +83,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -117,7 +117,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
@@ -148,7 +148,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -164,7 +164,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -177,7 +177,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -196,7 +196,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -209,7 +209,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/salko.h b/engines/lastexpress/entities/salko.h
index b177fbbfbf..0cf579736b 100644
--- a/engines/lastexpress/entities/salko.h
+++ b/engines/lastexpress/entities/salko.h
@@ -45,7 +45,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Draws the entity
@@ -61,7 +61,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Updates parameter 2 using time value
@@ -76,7 +76,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
DECLARE_FUNCTION_2(function7, CarIndex car, EntityPosition entityPosition)
@@ -85,7 +85,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -97,13 +97,13 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
DECLARE_FUNCTION(function13)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -116,7 +116,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -130,7 +130,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/sophie.h b/engines/lastexpress/entities/sophie.h
index 69f525ad3b..eea402e876 100644
--- a/engines/lastexpress/entities/sophie.h
+++ b/engines/lastexpress/entities/sophie.h
@@ -45,7 +45,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Handle chapters events
@@ -55,31 +55,31 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(function5)
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
DECLARE_FUNCTION(function9)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/tables.h b/engines/lastexpress/entities/tables.h
index 888b880f14..823ac90a63 100644
--- a/engines/lastexpress/entities/tables.h
+++ b/engines/lastexpress/entities/tables.h
@@ -37,27 +37,27 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Draws tables
diff --git a/engines/lastexpress/entities/tatiana.h b/engines/lastexpress/entities/tatiana.h
index b0e0a3295b..e6ab09237c 100644
--- a/engines/lastexpress/entities/tatiana.h
+++ b/engines/lastexpress/entities/tatiana.h
@@ -44,7 +44,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Draws the entity
@@ -68,7 +68,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Handles entering/exiting a compartment and updates position/play animation
@@ -119,7 +119,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -127,7 +127,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION(enterCompartment)
DECLARE_FUNCTION(exitCompartment)
@@ -136,7 +136,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(function18)
@@ -154,7 +154,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -169,7 +169,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION(playChess)
DECLARE_FUNCTION(returnToCompartment3)
@@ -193,7 +193,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
DECLARE_FUNCTION(inCompartment4)
DECLARE_FUNCTION(meetAlexei)
@@ -207,7 +207,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/train.h b/engines/lastexpress/entities/train.h
index fc6ac4c2ea..673a4c2810 100644
--- a/engines/lastexpress/entities/train.h
+++ b/engines/lastexpress/entities/train.h
@@ -40,32 +40,32 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Harem events
diff --git a/engines/lastexpress/entities/vassili.h b/engines/lastexpress/entities/vassili.h
index b043e10ba1..b3a0b20418 100644
--- a/engines/lastexpress/entities/vassili.h
+++ b/engines/lastexpress/entities/vassili.h
@@ -52,12 +52,12 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -74,21 +74,21 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
DECLARE_FUNCTION(sleeping)
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION(stealEgg)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -98,7 +98,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
};
} // End of namespace LastExpress
diff --git a/engines/lastexpress/entities/verges.h b/engines/lastexpress/entities/verges.h
index fada7e1d98..100320bb99 100644
--- a/engines/lastexpress/entities/verges.h
+++ b/engines/lastexpress/entities/verges.h
@@ -56,7 +56,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Plays sound
@@ -77,7 +77,7 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
/**
* Updates the entity
@@ -85,7 +85,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION_1(walkBetweenCars, const char *soundName)
DECLARE_FUNCTION_3(makeAnnouncement, CarIndex car, EntityPosition entityPosition, const char *soundName)
@@ -107,7 +107,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION_NOSETUP(talkHarem)
DECLARE_FUNCTION(talkPassengerList)
@@ -125,7 +125,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -135,7 +135,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION_1(function30, const char *soundName)
DECLARE_FUNCTION(talkAboutMax)
@@ -147,7 +147,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -159,7 +159,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/vesna.h b/engines/lastexpress/entities/vesna.h
index 6ac3b80822..2c8fb9d7f3 100644
--- a/engines/lastexpress/entities/vesna.h
+++ b/engines/lastexpress/entities/vesna.h
@@ -44,7 +44,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Handles entering/exiting a compartment.
@@ -52,7 +52,7 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Draws the entity
@@ -67,7 +67,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
/**
* Updates parameter 2 using time value
@@ -100,14 +100,14 @@ public:
* @param savegameType The type of the savegame
* @param param The param for the savegame (EventIndex or TimeValue)
*/
- DECLARE_FUNCTION_2(savegame, SavegameType savegameType, uint32 param)
+ DECLARE_VFUNCTION_2(savegame, SavegameType savegameType, uint32 param)
DECLARE_FUNCTION(homeAlone)
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(withMilos)
DECLARE_FUNCTION(homeTogether)
@@ -116,7 +116,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -128,7 +128,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION(inCompartment)
DECLARE_FUNCTION(takeAWalk)
@@ -138,7 +138,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
DECLARE_FUNCTION(exitLocation)
DECLARE_FUNCTION(done)
@@ -147,7 +147,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
DECLARE_FUNCTION(guarding)
DECLARE_FUNCTION(climbing)
diff --git a/engines/lastexpress/entities/waiter1.h b/engines/lastexpress/entities/waiter1.h
index bb4bc83f3e..e6516dbeff 100644
--- a/engines/lastexpress/entities/waiter1.h
+++ b/engines/lastexpress/entities/waiter1.h
@@ -78,7 +78,7 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
DECLARE_FUNCTION(rebeccaFeedUs)
DECLARE_FUNCTION(rebeccaClearOurTable)
@@ -88,7 +88,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(annaOrder)
DECLARE_FUNCTION(augustOrder)
DECLARE_FUNCTION(serveAnna)
@@ -104,7 +104,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
DECLARE_FUNCTION(inKitchen)
DECLARE_FUNCTION(augustComeHere2)
DECLARE_FUNCTION(augustClearTable2)
@@ -112,7 +112,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION(serving3)
DECLARE_FUNCTION(annaComeHere3)
DECLARE_FUNCTION(abbotServeLunch3)
@@ -120,7 +120,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
DECLARE_FUNCTION(serving4)
DECLARE_FUNCTION(augustOrder4)
DECLARE_FUNCTION(serveAugust4)
@@ -129,7 +129,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/waiter2.h b/engines/lastexpress/entities/waiter2.h
index 451f98d987..a563f78bf2 100644
--- a/engines/lastexpress/entities/waiter2.h
+++ b/engines/lastexpress/entities/waiter2.h
@@ -78,14 +78,14 @@ public:
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
DECLARE_FUNCTION(monsieurServeUs)
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
DECLARE_FUNCTION(milosOrder)
DECLARE_FUNCTION(monsieurOrder)
@@ -99,7 +99,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
DECLARE_FUNCTION(inKitchen)
DECLARE_FUNCTION(tatianaClearTableB)
DECLARE_FUNCTION(ivoComeHere)
@@ -108,14 +108,14 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
DECLARE_FUNCTION(serving3)
DECLARE_FUNCTION(annaBringTea3)
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
DECLARE_FUNCTION(serving4)
DECLARE_FUNCTION(augustNeedsADrink)
DECLARE_FUNCTION(serveAugustADrink)
@@ -124,7 +124,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
diff --git a/engines/lastexpress/entities/yasmin.h b/engines/lastexpress/entities/yasmin.h
index 93fe04b312..8aeaf240d6 100644
--- a/engines/lastexpress/entities/yasmin.h
+++ b/engines/lastexpress/entities/yasmin.h
@@ -45,14 +45,14 @@ public:
* @param sequence The sequence to draw
* @param compartment The compartment
*/
- DECLARE_FUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
+ DECLARE_VFUNCTION_2(enterExitCompartment, const char *sequence, ObjectIndex compartment)
/**
* Plays sound
*
* @param filename The sound filename
*/
- DECLARE_FUNCTION_1(playSound, const char *filename)
+ DECLARE_VFUNCTION_1(playSound, const char *filename)
/**
* Updates parameter 2 using time value
@@ -68,7 +68,7 @@ public:
* @param car The car
* @param entityPosition The entity position
*/
- DECLARE_FUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
+ DECLARE_VFUNCTION_2(updateEntity, CarIndex car, EntityPosition entityPosition)
DECLARE_FUNCTION(goEtoG)
DECLARE_FUNCTION(goGtoE)
@@ -76,7 +76,7 @@ public:
/**
* Setup Chapter 1
*/
- DECLARE_FUNCTION(chapter1)
+ DECLARE_VFUNCTION(chapter1)
/**
* Handle Chapter 1 events
@@ -88,7 +88,7 @@ public:
/**
* Setup Chapter 2
*/
- DECLARE_FUNCTION(chapter2)
+ DECLARE_VFUNCTION(chapter2)
/**
* Handle Chapter 2 events
@@ -98,7 +98,7 @@ public:
/**
* Setup Chapter 3
*/
- DECLARE_FUNCTION(chapter3)
+ DECLARE_VFUNCTION(chapter3)
/**
* Handle Chapter 3 events
@@ -108,7 +108,7 @@ public:
/**
* Setup Chapter 4
*/
- DECLARE_FUNCTION(chapter4)
+ DECLARE_VFUNCTION(chapter4)
/**
* Handle Chapter 4 events
@@ -120,7 +120,7 @@ public:
/**
* Setup Chapter 5
*/
- DECLARE_FUNCTION(chapter5)
+ DECLARE_VFUNCTION(chapter5)
/**
* Handle Chapter 5 events
Commit: 2a5f16faac956ab1b2e2c18e71c5da41bf22b578
https://github.com/scummvm/scummvm/commit/2a5f16faac956ab1b2e2c18e71c5da41bf22b578
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-04-24T01:40:06+02:00
Commit Message:
QUEEN: Added override keyword
Changed paths:
engines/queen/queen.h
diff --git a/engines/queen/queen.h b/engines/queen/queen.h
index 7c6ddb20d3..579a2fb435 100644
--- a/engines/queen/queen.h
+++ b/engines/queen/queen.h
@@ -98,7 +98,7 @@ public:
bool canSaveGameStateCurrently() override;
Common::Error saveGameState(int slot, const Common::String &desc, bool isAutosave = false) override;
Common::Error loadGameState(int slot) override;
- virtual int getAutosaveSlot() const { return 99; }
+ virtual int getAutosaveSlot() const override { return 99; }
virtual Common::String getSaveStateName(int slot) const override;
void makeGameStateName(int slot, char *buf) const;
int getGameStateSlot(const char *filename) const;
Commit: 786af20bc7f338eacd45df3d80149e802c4a427e
https://github.com/scummvm/scummvm/commit/786af20bc7f338eacd45df3d80149e802c4a427e
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-04-24T01:41:22+02:00
Commit Message:
WINTERMUTE: Added override keyword
Changed paths:
engines/wintermute/detection.cpp
diff --git a/engines/wintermute/detection.cpp b/engines/wintermute/detection.cpp
index d4743c8e81..4f888fd3f7 100644
--- a/engines/wintermute/detection.cpp
+++ b/engines/wintermute/detection.cpp
@@ -215,13 +215,13 @@ public:
return retVal;
}
- Common::KeymapArray initKeymaps(const char *target) const {
+ Common::KeymapArray initKeymaps(const char *target) const override {
using namespace Common;
Keymap *engineKeyMap = new Keymap(Keymap::kKeymapTypeGame, "wintermute", "Wintermute engine");
Action *act;
-
+
act = new Action("LCLK", _("Left Click"));
act->setLeftClickEvent();
act->addDefaultInputMapping("MOUSE_LEFT"); // original mouse
More information about the Scummvm-git-logs
mailing list