[Scummvm-git-logs] scummvm master -> 022e6c138c00af580f55cae3329f67c4d040b5a8

[rvanlaar]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
022e6c138c DIRECTOR: LINGO: Warn chars is called with float


Commit: 022e6c138c00af580f55cae3329f67c4d040b5a8
    https://github.com/scummvm/scummvm/commit/022e6c138c00af580f55cae3329f67c4d040b5a8
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2020-08-04T21:46:12+02:00

Commit Message:
DIRECTOR: LINGO: Warn chars is called with float

Director 2 and 3 can't handle floats in the chars builtin.
ScummVM can, but warns and returns a 0.

Changed paths:
    engines/director/lingo/lingo-builtins.cpp


diff --git a/engines/director/lingo/lingo-builtins.cpp b/engines/director/lingo/lingo-builtins.cpp
index 5ed1f646e7..5ae1148e2d 100644
--- a/engines/director/lingo/lingo-builtins.cpp
+++ b/engines/director/lingo/lingo-builtins.cpp
@@ -451,7 +451,7 @@ void LB::b_chars(int nargs) {
 	TYPECHECK2(s, STRING, FIELDREF);
 
 	if (g_director->getVersion() < 4 && (d2.type == FLOAT || d3.type == FLOAT)) {
-		// D3 throws an error when called with a float.
+		warning("LB::b_chars: Called with a float in Director 2 and 3 mode. chars' can't handle floats");
 		g_lingo->push(Datum(0));
 		return;
 	}