[Scummvm-git-logs] scummvm master -> 57cd0741ae5169a6fb0d22660bc2f0a5a3d1dcd7

[SupSuper]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
57cd0741ae CREATE_PROJECT: Disable MSVC virtual inheritance warnings


Commit: 57cd0741ae5169a6fb0d22660bc2f0a5a3d1dcd7
    https://github.com/scummvm/scummvm/commit/57cd0741ae5169a6fb0d22660bc2f0a5a3d1dcd7
Author: Daniel (supsuper at gmail.com)
Date: 2020-08-15T08:45:35+01:00

Commit Message:
CREATE_PROJECT: Disable MSVC virtual inheritance warnings

Noisy and doesn't look like it's getting a "proper" fix anytime soon

Changed paths:
    devtools/create_project/create_project.cpp


diff --git a/devtools/create_project/create_project.cpp b/devtools/create_project/create_project.cpp
index 13990de923..2ee3a43c3e 100644
--- a/devtools/create_project/create_project.cpp
+++ b/devtools/create_project/create_project.cpp
@@ -551,6 +551,9 @@ int main(int argc, char *argv[]) {
 		//
 		// 4577 ('noexcept' used with no exception handling mode specified)
 		//
+		// 4589 (Constructor of abstract class 'type' ignores initializer for virtual base class 'type')
+		//   caused by Common::Stream virtual inheritance, should be harmless
+		//
 		// 4702 (unreachable code)
 		//   mostly thrown after error() calls (marked as NORETURN)
 		//
@@ -599,6 +602,7 @@ int main(int argc, char *argv[]) {
 		globalWarnings.push_back("4345");
 		globalWarnings.push_back("4351");
 		globalWarnings.push_back("4512");
+		globalWarnings.push_back("4589");
 		globalWarnings.push_back("4702");
 		globalWarnings.push_back("4706");
 		globalWarnings.push_back("4800");