[Scummvm-git-logs] scummvm master -> 1f486c4442024a7995a5606292cee5265111f339

[sev-]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
53c485d85b DIRECTOR: Add catchers for unprocessed chunks
1f486c4442 PINK: Show message for unimplemented menu items. Addresses #11318


Commit: 53c485d85b0f5f8c7f6b211dd82d61a0ba67e2e3
    https://github.com/scummvm/scummvm/commit/53c485d85b0f5f8c7f6b211dd82d61a0ba67e2e3
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-08-27T18:00:44+02:00

Commit Message:
DIRECTOR: Add catchers for unprocessed chunks

Changed paths:
    engines/director/cast.cpp


diff --git a/engines/director/cast.cpp b/engines/director/cast.cpp
index cf2cfabceb..b2ddde7b7a 100644
--- a/engines/director/cast.cpp
+++ b/engines/director/cast.cpp
@@ -260,6 +260,12 @@ bool Cast::loadArchive() {
 		debug("STUB: Unhandled VWtc resource");
 	}
 
+	// Tape Key resource. Perhaps a lookup for labels?
+	// TODO: Is this a score resource?
+	if (_castArchive->hasResource(MKTAG('V', 'W', 't', 'k'), -1)) {
+		debug("STUB: Unhandled VWtk resource");
+	}
+
 	// External sound files
 	if (_castArchive->hasResource(MKTAG('S', 'T', 'R', ' '), -1)) {
 		debug("STUB: Unhandled 'STR ' resource");
@@ -314,6 +320,16 @@ bool Cast::loadArchive() {
 		debug("STUB: Unhandled 'SCVW' resource");
 	}
 
+	// External Cast Reference resources
+	if (_castArchive->hasResource(MKTAG('S', 'C', 'R', 'F'), -1)) {
+		debug("STUB: Unhandled 'SCRF' resource");
+	}
+
+	// Score Order List resources
+	if (_castArchive->hasResource(MKTAG('S', 'o', 'r', 'd'), -1)) {
+		debug("STUB: Unhandled 'Sord' resource");
+	}
+
 	// Now process STXTs
 	Common::Array<uint16> stxt = _castArchive->getResourceIDList(MKTAG('S','T','X','T'));
 	debugC(2, kDebugLoading, "****** Loading %d STXT resources", stxt.size());


Commit: 1f486c4442024a7995a5606292cee5265111f339
    https://github.com/scummvm/scummvm/commit/1f486c4442024a7995a5606292cee5265111f339
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2020-08-27T18:00:44+02:00

Commit Message:
PINK: Show message for unimplemented menu items. Addresses #11318

Changed paths:
  A engines/pink/POTFILES
    engines/pink/gui.cpp


diff --git a/engines/pink/POTFILES b/engines/pink/POTFILES
new file mode 100644
index 0000000000..f1159a9a1a
--- /dev/null
+++ b/engines/pink/POTFILES
@@ -0,0 +1 @@
+engines/pink/gui.cpp
diff --git a/engines/pink/gui.cpp b/engines/pink/gui.cpp
index 1e97eb86c1..5d65f3f774 100644
--- a/engines/pink/gui.cpp
+++ b/engines/pink/gui.cpp
@@ -21,10 +21,13 @@
  */
 
 #include "common/config-manager.h"
+#include "common/translation.h"
 
 #include "graphics/macgui/macwindowmanager.h"
 #include "graphics/macgui/macmenu.h"
 
+#include "gui/message.h"
+
 #include "pink/pink.h"
 #include "pink/director.h"
 #include "pink/objects/actors/lead_actor.h"
@@ -213,7 +216,11 @@ void PinkEngine::executeMenuCommand(uint id) {
 		break;
 
 	default:
-		warning("Unprocessed command id %d", id);
+		{
+			GUI::MessageDialog dialog(_("This menu item is not yet implemented"));
+			dialog.runModal();
+			warning("Unprocessed command id %d", id);
+		}
 		break;
 	}
 }