[Scummvm-git-logs] scummvm branch-2-1 -> 00b78af1f0268052d2e7ab6b75c0b3d3c58b9500

antoniou79 a.antoniou79 at gmail.com
Mon Jan 13 12:14:29 UTC 2020


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
00b78af1f0 GRAPHICS: Fix modern theme tab widgets being 2px too tall


Commit: 00b78af1f0268052d2e7ab6b75c0b3d3c58b9500
    https://github.com/scummvm/scummvm/commit/00b78af1f0268052d2e7ab6b75c0b3d3c58b9500
Author: Bastien Bouclet (bastien.bouclet at gmail.com)
Date: 2020-01-13T14:12:44+02:00

Commit Message:
GRAPHICS: Fix modern theme tab widgets being 2px too tall

This was noticeable in the graphics tab of the options dialog when
scrolling down. The widgets would be partially drawn on top of the
tabs.

Changed paths:
    graphics/VectorRendererSpec.cpp


diff --git a/graphics/VectorRendererSpec.cpp b/graphics/VectorRendererSpec.cpp
index 9650e93..e0324a4 100644
--- a/graphics/VectorRendererSpec.cpp
+++ b/graphics/VectorRendererSpec.cpp
@@ -1843,7 +1843,7 @@ drawTabAlg(int x1, int y1, int w, int h, int r, PixelType color, VectorRenderer:
 	PixelType *ptr_fill = (PixelType *)Base::_activeSurface->getBasePtr(x1, y1);
 
 	int real_radius = r;
-	int short_h = h - r + 2;
+	int short_h = h - r;
 	int long_h = h;
 
 	if (fill_m == kFillDisabled) {
@@ -1948,7 +1948,7 @@ drawTabAlgClip(int x1, int y1, int w, int h, int r, PixelType color, VectorRende
 	int fill_x = x1, fill_y = y1;
 
 	int real_radius = r;
-	int short_h = h - r + 2;
+	int short_h = h - r;
 	int long_h = h;
 
 	if (fill_m == kFillDisabled) {
@@ -2065,7 +2065,7 @@ drawTabShadow(int x1, int y1, int w, int h, int r) {
 		PixelType *ptr_tr = (PixelType *)Base::_activeSurface->getBasePtr(xstart + width - r, ystart + r);
 		PixelType *ptr_fill = (PixelType *)Base::_activeSurface->getBasePtr(xstart, ystart);
 
-		int short_h = height - (2 * r) + 2;
+		int short_h = height - (2 * r);
 		PixelType color = _format.RGBToColor(0, 0, 0);
 
 		BE_RESET();
@@ -2129,7 +2129,7 @@ drawTabShadowClip(int x1, int y1, int w, int h, int r) {
 		int tl_x = xstart + r, tl_y = ystart + r;
 		int fill_x = xstart, fill_y = ystart;
 
-		int short_h = height - (2 * r) + 2;
+		int short_h = height - (2 * r);
 		PixelType color = _format.RGBToColor(0, 0, 0);
 
 		BE_RESET();
@@ -3865,7 +3865,7 @@ drawTabAlg(int x1, int y1, int w, int h, int r, PixelType color, VectorRenderer:
 			}
 		}
 
-		int short_h = h - r + 2;
+		int short_h = h - r;
 
 		ptr_fill += pitch * real_radius;
 		while (short_h--) {
@@ -3896,7 +3896,7 @@ drawTabAlg(int x1, int y1, int w, int h, int r, PixelType color, VectorRenderer:
 		color1 = color2 = color;
 
 		int long_h = h;
-		int short_h = h - real_radius + 2;
+		int short_h = h - real_radius;
 		x = real_radius;
 		y = 0;
 		T = 0;




More information about the Scummvm-git-logs mailing list