[Scummvm-git-logs] scummvm master -> 533bab342b334cc649b48906d16c0c70a00111cb

npjg nathanael.gentrydb8 at gmail.com
Fri Jul 3 13:41:53 UTC 2020


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
533bab342b DIRECTOR: Fix dissolve transition calculation


Commit: 533bab342b334cc649b48906d16c0c70a00111cb
    https://github.com/scummvm/scummvm/commit/533bab342b334cc649b48906d16c0c70a00111cb
Author: Nathanael Gentry (nathanael.gentrydb8 at gmail.com)
Date: 2020-07-03T09:41:01-04:00

Commit Message:
DIRECTOR: Fix dissolve transition calculation

Without this, rnd is never 0 and so the transition is never drawn around
point (0, 0).

Changed paths:
    engines/director/transitions.cpp


diff --git a/engines/director/transitions.cpp b/engines/director/transitions.cpp
index ba86a91cd9..c9119fba56 100644
--- a/engines/director/transitions.cpp
+++ b/engines/director/transitions.cpp
@@ -660,8 +660,8 @@ void Stage::dissolveTrans(TransParams &t, Common::Rect &clipRect, Graphics::Mana
 	for (int i = 0; i < t.steps; i++) {
 		uint32 pixPerStep = pixPerStepInit;
 		do {
-			uint32 x = rnd >> vShift;
-			uint32 y = rnd & hMask;
+			uint32 x = (rnd - 1) >> vShift;
+			uint32 y = (rnd - 1) & hMask;
 			byte mask = 0;
 
 			r.setWidth(MAX(1, t.xStepSize));




More information about the Scummvm-git-logs mailing list