[Scummvm-git-logs] scummvm master -> 22842d1a88430d206343620700e19a42e914172a

[sev-]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2a239efa80 GUI: Always mark editable as dirty when press home or end
22842d1a88 GUI: RTL: Do not repeatedly print warnings if fribidi is not available


Commit: 2a239efa80ba65ec2e7a059d4a3d9f3fa2572872
    https://github.com/scummvm/scummvm/commit/2a239efa80ba65ec2e7a059d4a3d9f3fa2572872
Author: aryanrawlani28 (aryanrawlani007 at gmail.com)
Date: 2020-07-25T00:32:34+02:00

Commit Message:
GUI: Always mark editable as dirty when press home or end

- Before, the implementation used to fetch this value based on setCaretPos.
- That would return true only if string needed scrolling.
- Thus, the small issue arised that 2 chars would be wobbled together. This commit fixes that.

Changed paths:
    gui/widgets/editable.cpp


diff --git a/gui/widgets/editable.cpp b/gui/widgets/editable.cpp
index 2849350fc9..1934056c34 100644
--- a/gui/widgets/editable.cpp
+++ b/gui/widgets/editable.cpp
@@ -163,8 +163,9 @@ bool EditableWidget::handleKeyDown(Common::KeyState state) {
 	case Common::KEYCODE_DOWN:
 	case Common::KEYCODE_END:
 		// Move caret to end
-		dirty = setCaretPos(_editString.size());
+		setCaretPos(_editString.size());
 		forcecaret = true;
+		dirty = true;
 		break;
 
 	case Common::KEYCODE_LEFT:
@@ -188,8 +189,9 @@ bool EditableWidget::handleKeyDown(Common::KeyState state) {
 	case Common::KEYCODE_UP:
 	case Common::KEYCODE_HOME:
 		// Move caret to start
-		dirty = setCaretPos(0);
+		setCaretPos(0);
 		forcecaret = true;
+		dirty = true;
 		break;
 
 	case Common::KEYCODE_v:


Commit: 22842d1a88430d206343620700e19a42e914172a
    https://github.com/scummvm/scummvm/commit/22842d1a88430d206343620700e19a42e914172a
Author: aryanrawlani28 (aryanrawlani007 at gmail.com)
Date: 2020-07-25T00:32:34+02:00

Commit Message:
GUI: RTL: Do not repeatedly print warnings if fribidi is not available

- Previously, if using an RTL-based language and disabled fribidi, console would repeatedly have the same messages spamming.
- Reduce this to only print warning one time.

Changed paths:
    common/unicode-bidi.cpp


diff --git a/common/unicode-bidi.cpp b/common/unicode-bidi.cpp
index ef443ab338..44f8ca2cc1 100644
--- a/common/unicode-bidi.cpp
+++ b/common/unicode-bidi.cpp
@@ -89,7 +89,11 @@ void UnicodeBiDiText::initWithU32String(const U32String &input) {
 		delete[] visual_str;
 	}
 #else
-	warning("initWithU32String: Fribidi not available, using input string as fallback");
+	static bool fribidiWarning = true;
+	if (fribidiWarning) {
+		warning("initWithU32String: Fribidi not available, will use input strings as fallback.");
+		fribidiWarning = false;
+	}
 	visual = input;
 #endif