[Scummvm-git-logs] scummvm master -> c777d66f927dee9006e3bba4b25e7f27ddf3bf5b

bgK bastien.bouclet at gmail.com
Sun Jun 21 14:51:57 UTC 2020


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
c777d66f92 SCUMM: Use OSystem::fillScreen when clearing the screen in MM NES


Commit: c777d66f927dee9006e3bba4b25e7f27ddf3bf5b
    https://github.com/scummvm/scummvm/commit/c777d66f927dee9006e3bba4b25e7f27ddf3bf5b
Author: Bastien Bouclet (bastien.bouclet at gmail.com)
Date: 2020-06-21T16:46:13+02:00

Commit Message:
SCUMM: Use OSystem::fillScreen when clearing the screen in MM NES

The previous code was allocating a temporary surface on the stack which
was causing the stack to overflow on the 3DS.

Fixes #11505.

Changed paths:
    engines/scumm/gfx.cpp


diff --git a/engines/scumm/gfx.cpp b/engines/scumm/gfx.cpp
index 7957f50020..35d6a1e276 100644
--- a/engines/scumm/gfx.cpp
+++ b/engines/scumm/gfx.cpp
@@ -641,9 +641,7 @@ void ScummEngine::drawStripToScreen(VirtScreen *vs, int x, int width, int top, i
 
 	// In MM NES If we're repainting the entire screen, just make everything black
 	if ((_game.platform == Common::kPlatformNES) && width == 256 && height == 240) {
-		byte blackbuf[256 * 240];
-		memset(blackbuf, 0x1d, 256 * 240);
-		_system->copyRectToScreen(blackbuf, pitch, x, y, width, height);
+		_system->fillScreen(0x1d);
 		return;
 	}
 




More information about the Scummvm-git-logs mailing list